fix: `p-limit` should be dep instead #212

JounQin · 2025-04-03T21:35:33Z

Summary by CodeRabbit

Documentation
- Updated project documentation with enhanced badges and refined link formatting for clearer project status and consistent information display.
Chores
- Reorganized dependency classifications and updated package details to ensure improved configuration and stability.
- Streamlined automation workflows by renaming steps and adjusting trigger conditions to enhance clarity and performance.

changeset-bot · 2025-04-03T21:35:36Z

🦋 Changeset detected

Latest commit: a0fcbe6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
changesets-gitlab	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-04-03T21:35:41Z

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several configuration and metadata updates. A new changeset file now reclassifies the p-limit dependency as a direct dependency, and corresponding adjustments have been made in package metadata. Multiple GitHub Actions workflows have been modified—one removed entirely, one with an added step name, and another with streamlined triggers and renamed steps. Additionally, badge links in the README have been updated for clarity, and a minor code style change has been applied to a conditional in the source code.

Changes

File(s)	Change Summary
`.changeset/cuddly-yaks-perform.md`, `package.json`	Reclassified `p-limit` from a dev dependency to a direct dependency; updated dependency version and rearranged the author field in package metadata.
`.github/workflows/codeql.yml`, `.github/workflows/pkg-pr-new.yml`, `.github/workflows/size-limit.yml`	Removed the CodeQL workflow; in pkg-pr-new, added a "Publish" name to the step; in size-limit, removed a branch trigger and permissions section and renamed a step to "Check Size Limit".
`README.md`	Revised badges and link formatting with enhanced descriptions and corrected casing.
`src/comment.ts`	Refactored the conditional check in `getReleasePlanMessage` from a single-line return to a block statement for improved readability.

Sequence Diagram(s)

sequenceDiagram
    participant Repo as Repository
    participant Runner as GitHub Actions Runner
    participant Publish as "Publish Step"
    
    Repo->>Runner: Trigger pkg-pr-new workflow
    Runner->>Publish: Execute step "Publish" (runs yarn dlx pkg-pr-new publish --compact)
    Publish-->>Runner: Return result

sequenceDiagram
    participant Repo as Repository
    participant Runner as GitHub Actions Runner
    participant SizeCheck as "Check Size Limit"
    
    Repo->>Runner: Trigger size-limit workflow on pull_request
    Runner->>SizeCheck: Run step "Check Size Limit" using size-limit-action
    SizeCheck-->>Runner: Return result

Possibly related PRs

chore: release package(s) #208: Addresses similar dependency reclassification for p-limit and involves concurrency-related adjustments, indicating a direct code-level connection.

Poem

I hopped through lines of code so bright,
Adjusting workflows with all my might.
Dependencies pranced into their proper place,
Badges and links now set with grace.
With each little tweak, my ears stand tall—
A rabbit’s joy in every change, one and all!
🐰🌟

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/comment.ts

Oops! Something went wrong! :(

ESLint: 9.23.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27afaae and a0fcbe6.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (7)

.changeset/cuddly-yaks-perform.md (1 hunks)
.github/workflows/codeql.yml (0 hunks)
.github/workflows/pkg-pr-new.yml (1 hunks)
.github/workflows/size-limit.yml (1 hunks)
README.md (2 hunks)
package.json (3 hunks)
src/comment.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)

.github/workflows/codeql.yml: Language not supported
package.json: Language not supported

Comments suppressed due to low confidence (1)

.github/workflows/size-limit.yml:7

The explicit permissions block has been removed. Please verify that the default permissions provided to the workflow remain sufficient for all operations.

-permissions:

sonarqubecloud · 2025-04-03T21:36:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codesandbox-ci · 2025-04-03T21:36:15Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

pkg-pr-new · 2025-04-03T21:36:25Z

Open in StackBlitz

npm i https://pkg.pr.new/changesets-gitlab@212

commit: a0fcbe6

github-actions · 2025-04-03T21:36:44Z

📊 Package size report `-3.11%↓`

File	Before	After
`lib/comment.js`	`9.4 kB`	^0.09%↑`9.4 kB`
`lib/comment.js.map`	`7.3 kB`	^0.3%↑`7.3 kB`
`lib/index.cjs`	`44.0 kB`	^-10.1%↓`39.6 kB`
`README.md`	`11.6 kB`	^2%↑`11.8 kB`
Total _{(Includes all files)}	`136.5 kB`	^-3.11%↓`132.3 kB`
Tarball size	`35.8 kB`	^-6.9%↓`33.3 kB`

Unchanged files

File	Size
`index.d.cts`	`73 B`
`lib/api.d.ts`	`99 B`
`lib/api.js`	`899 B`
`lib/api.js.map`	`1.0 kB`
`lib/cli.d.ts`	`39 B`
`lib/cli.js`	`734 B`
`lib/cli.js.map`	`932 B`
`lib/comment.d.ts`	`247 B`
`lib/context.d.ts`	`74 B`
`lib/context.js`	`138 B`
`lib/context.js.map`	`228 B`
`lib/env.d.ts`	`70 B`
`lib/env.js`	`857 B`
`lib/env.js.map`	`778 B`
`lib/get-changed-packages.d.ts`	`305 B`
`lib/get-changed-packages.js`	`4.8 kB`
`lib/get-changed-packages.js.map`	`4.7 kB`
`lib/git-utils.d.ts`	`646 B`
`lib/git-utils.js`	`1.7 kB`
`lib/git-utils.js.map`	`2.2 kB`
`lib/index.d.ts`	`274 B`
`lib/index.js`	`241 B`
`lib/index.js.map`	`249 B`
`lib/main.d.ts`	`153 B`
`lib/main.js`	`3.6 kB`
`lib/main.js.map`	`3.1 kB`
`lib/read-changeset-state.d.ts`	`252 B`
`lib/read-changeset-state.js`	`650 B`
`lib/read-changeset-state.js.map`	`767 B`
`lib/run.d.ts`	`1.1 kB`
`lib/run.js`	`8.8 kB`
`lib/run.js.map`	`8.1 kB`
`lib/types.d.ts`	`1.2 kB`
`lib/types.js`	`44 B`
`lib/types.js.map`	`102 B`
`lib/utils.d.ts`	`1.6 kB`
`lib/utils.js`	`4.2 kB`
`lib/utils.js.map`	`4.8 kB`
`LICENSE`	`1.1 kB`
`package.json`	`3.5 kB`

_{🤖 This report was automatically generated by pkg-size-action}

socket-security · 2025-04-03T21:36:48Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@1stg/[email protected] ➜ 5.0.4	None	`0`	17.3 kB	jounqin
npm/@1stg/[email protected] ➜ 11.1.2	None	`0`	47 kB	jounqin
npm/@1stg/[email protected] ➜ 1.0.2	None	`0`	6.3 kB	jounqin
npm/@1stg/[email protected] ➜ 8.3.2	None	`0`	85.1 kB	jounqin
npm/@1stg/[email protected] ➜ 4.0.7	None	`0`	37 kB	jounqin
npm/@1stg/[email protected] ➜ 4.0.2	None	`0`	9.76 kB	jounqin
npm/@1stg/[email protected] ➜ 4.0.7	None	`0`	31.1 kB	jounqin
npm/@1stg/[email protected] ➜ 3.0.2	None	`0`	12.1 kB	jounqin
npm/@1stg/[email protected] ➜ 1.0.2	None	`0`	7.03 kB	jounqin
npm/@1stg/[email protected] ➜ 3.0.2	None	`0`	17.3 kB	jounqin
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	92.8 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	142 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	48.5 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	819 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	33 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	22.5 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	184 kB	rel1cx
npm/@eslint-react/[email protected] ➜ 1.40.3	None	`0`	31.8 kB	rel1cx
npm/@vitest/[email protected] ➜ 1.1.39	None	`0`	284 kB	veritemm
npm/[email protected] ➜ 5.2.6	None	`0`	33.1 kB	bpscott, jounqin, lydell, ...3 more
npm/[email protected] ➜ 1.40.3	None	`0`	23.3 kB	rel1cx
npm/[email protected] ➜ 1.40.3	None	`0`	132 kB	rel1cx
npm/[email protected] ➜ 1.40.3	None	`0`	66.1 kB	rel1cx
npm/[email protected] ➜ 1.40.3	None	`0`	42 kB	rel1cx
npm/[email protected] ➜ 1.40.3	None	`0`	59.2 kB	rel1cx
npm/[email protected] ➜ 1.40.3	None	`0`	337 kB	rel1cx
npm/[email protected]	None	`0`	1.67 MB	fabian-hiller
npm/[email protected]	None	`0`	8.01 kB	sindresorhus

View full report↗︎

fix: p-limit should be dep instead

6495841

JounQin requested a review from Copilot April 3, 2025 21:35

Create cuddly-yaks-perform.md

a0fcbe6

Copilot AI reviewed Apr 3, 2025

View reviewed changes

JounQin merged commit 7d1eb71 into main Apr 3, 2025
18 checks passed

JounQin deleted the fix/p-limit branch April 3, 2025 21:37

github-actions bot mentioned this pull request Apr 3, 2025

chore: release package(s) #213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: `p-limit` should be dep instead #212

fix: `p-limit` should be dep instead #212

Uh oh!

JounQin commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud bot commented Apr 3, 2025

Uh oh!

codesandbox-ci bot commented Apr 3, 2025

Uh oh!

pkg-pr-new bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

socket-security bot commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: p-limit should be dep instead #212

fix: p-limit should be dep instead #212

Uh oh!

Conversation

JounQin commented Apr 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 3, 2025

Quality Gate passed

Uh oh!

codesandbox-ci bot commented Apr 3, 2025

Uh oh!

pkg-pr-new bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

📊 Package size report -3.11%↓

Uh oh!

socket-security bot commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

fix: `p-limit` should be dep instead #212

fix: `p-limit` should be dep instead #212

JounQin commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Apr 3, 2025 •

edited

Loading

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Apr 3, 2025 •

edited

Loading

📊 Package size report `-3.11%↓`