Skip to content

Commit 7d1eb71

Browse files
authored
fix: p-limit should be dep instead (#212)
1 parent 27afaae commit 7d1eb71

File tree

8 files changed

+238
-257
lines changed

8 files changed

+238
-257
lines changed

.changeset/cuddly-yaks-perform.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"changesets-gitlab": patch
3+
---
4+
5+
fix: `p-limit` should be dep instead

.github/workflows/codeql.yml

Lines changed: 0 additions & 48 deletions
This file was deleted.

.github/workflows/pkg-pr-new.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@ jobs:
2727
- name: Build
2828
run: yarn build
2929

30-
- run: yarn dlx pkg-pr-new publish --compact
30+
- name: Publish
31+
run: yarn dlx pkg-pr-new publish --compact

.github/workflows/size-limit.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
pull_request:
55
branches:
66
- master
7-
- v3.x
8-
9-
permissions:
10-
contents: read
11-
pull-requests: write
127

138
concurrency:
149
group: ${{ github.workflow }}-${{ github.ref }}
@@ -29,7 +24,8 @@ jobs:
2924
- name: Install Dependencies
3025
run: yarn --immutable
3126

32-
- uses: andresz1/size-limit-action@94bc357df29c36c8f8d50ea497c3e225c3c95d1d # v1.8.0
27+
- name: Check Size Limit
28+
uses: andresz1/size-limit-action@94bc357df29c36c8f8d50ea497c3e225c3c95d1d # v1.8.0
3329
with:
3430
github_token: ${{ secrets.GITHUB_TOKEN }}
3531
skip_step: install

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# changesets-gitlab
22

3-
[![GitHub Actions](https://github.com/un-ts/changesets-gitlab/workflows/CI/badge.svg)](https://github.com/un-ts/changesets-gitlab/actions/workflows/ci.yml)
3+
[![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/un-ts/changesets-gitlab/ci.yml?branch=main)](https://github.com/un-ts/changesets-gitlab/actions/workflows/ci.yml?query=branch%3Amain)
4+
[![CodeRabbit Pull Request Reviews](https://img.shields.io/coderabbit/prs/github/un-ts/changesets-gitlab)](https://coderabbit.ai)
45
[![npm](https://img.shields.io/npm/v/changesets-gitlab.svg)](https://www.npmjs.com/package/changesets-gitlab)
56
[![GitHub Release](https://img.shields.io/github/release/un-ts/changesets-gitlab)](https://github.com/un-ts/changesets-gitlab/releases)
67

@@ -229,6 +230,6 @@ Detailed changes for each release are documented in [CHANGELOG.md](./CHANGELOG.m
229230

230231
[MIT][] © [JounQin][]@[1stG.me][]
231232

232-
[1stg.me]: https://www.1stg.me
233-
[jounqin]: https://GitHub.com/JounQin
234-
[mit]: http://opensource.org/licenses/MIT
233+
[1stG.me]: https://www.1stG.me
234+
[JounQin]: https://github.com/JounQin
235+
[MIT]: http://opensource.org/licenses/MIT

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.13.0",
44
"type": "module",
55
"repository": "https://github.com/un-ts/changesets-gitlab.git",
6-
"author": "JounQin (https://www.1stG.me) <[email protected]>",
6+
"author": "JounQin <[email protected]> (https://www.1stG.me)",
77
"funding": "https://opencollective.com/changesets-gitlab",
88
"license": "MIT",
99
"packageManager": "[email protected]",
@@ -79,6 +79,7 @@
7979
"markdown-table": "^3.0.4",
8080
"mdast-util-to-string": "^4.0.0",
8181
"micromatch": "^4.0.8",
82+
"p-limit": "^6.2.0",
8283
"remark-parse": "^11.0.0",
8384
"remark-stringify": "^11.0.0",
8485
"resolve-from": "^5.0.0",
@@ -87,7 +88,7 @@
8788
"yaml": "^2.7.1"
8889
},
8990
"devDependencies": {
90-
"@1stg/common-config": "^11.1.1",
91+
"@1stg/common-config": "^11.1.2",
9192
"@changesets/changelog-github": "^0.5.1",
9293
"@changesets/cli": "^2.28.1",
9394
"@commitlint/cli": "^19.8.0",
@@ -100,7 +101,6 @@
100101
"eslint": "^9.23.0",
101102
"lint-staged": "^15.5.0",
102103
"npm-run-all2": "^7.0.2",
103-
"p-limit": "^6.2.0",
104104
"prettier": "^3.5.3",
105105
"simple-git-hooks": "^2.12.1",
106106
"size-limit": "^11.2.0",

src/comment.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ import { getUsername, HTTP_STATUS_NOT_FOUND, TRUTHY_VALUES } from './utils.js'
2626
const generatedByBotNote = 'Generated By Changesets GitLab Bot'
2727

2828
const getReleasePlanMessage = (releasePlan: ReleasePlan | null) => {
29-
if (!releasePlan) return ''
29+
if (!releasePlan) {
30+
return ''
31+
}
3032

3133
const publishableReleases = releasePlan.releases.filter(
3234
(x): x is ComprehensiveRelease & { type: Exclude<VersionType, 'none'> } =>

0 commit comments

Comments
 (0)