Skip to content

fix: p-limit should be dep instead #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-yaks-perform.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"changesets-gitlab": patch
---

fix: `p-limit` should be dep instead
48 changes: 0 additions & 48 deletions .github/workflows/codeql.yml

This file was deleted.

3 changes: 2 additions & 1 deletion .github/workflows/pkg-pr-new.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ jobs:
- name: Build
run: yarn build

- run: yarn dlx pkg-pr-new publish --compact
- name: Publish
run: yarn dlx pkg-pr-new publish --compact
8 changes: 2 additions & 6 deletions .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ on:
pull_request:
branches:
- master
- v3.x

permissions:
contents: read
pull-requests: write

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -29,7 +24,8 @@ jobs:
- name: Install Dependencies
run: yarn --immutable

- uses: andresz1/size-limit-action@94bc357df29c36c8f8d50ea497c3e225c3c95d1d # v1.8.0
- name: Check Size Limit
uses: andresz1/size-limit-action@94bc357df29c36c8f8d50ea497c3e225c3c95d1d # v1.8.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
skip_step: install
Expand Down
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# changesets-gitlab

[![GitHub Actions](https://github.com/un-ts/changesets-gitlab/workflows/CI/badge.svg)](https://github.com/un-ts/changesets-gitlab/actions/workflows/ci.yml)
[![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/un-ts/changesets-gitlab/ci.yml?branch=main)](https://github.com/un-ts/changesets-gitlab/actions/workflows/ci.yml?query=branch%3Amain)
[![CodeRabbit Pull Request Reviews](https://img.shields.io/coderabbit/prs/github/un-ts/changesets-gitlab)](https://coderabbit.ai)
[![npm](https://img.shields.io/npm/v/changesets-gitlab.svg)](https://www.npmjs.com/package/changesets-gitlab)
[![GitHub Release](https://img.shields.io/github/release/un-ts/changesets-gitlab)](https://github.com/un-ts/changesets-gitlab/releases)

Expand Down Expand Up @@ -229,6 +230,6 @@ Detailed changes for each release are documented in [CHANGELOG.md](./CHANGELOG.m

[MIT][] © [JounQin][]@[1stG.me][]

[1stg.me]: https://www.1stg.me
[jounqin]: https://GitHub.com/JounQin
[mit]: http://opensource.org/licenses/MIT
[1stG.me]: https://www.1stG.me
[JounQin]: https://github.com/JounQin
[MIT]: http://opensource.org/licenses/MIT
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.13.0",
"type": "module",
"repository": "https://github.com/un-ts/changesets-gitlab.git",
"author": "JounQin (https://www.1stG.me) <[email protected]>",
"author": "JounQin <[email protected]> (https://www.1stG.me)",
"funding": "https://opencollective.com/changesets-gitlab",
"license": "MIT",
"packageManager": "[email protected]",
Expand Down Expand Up @@ -79,6 +79,7 @@
"markdown-table": "^3.0.4",
"mdast-util-to-string": "^4.0.0",
"micromatch": "^4.0.8",
"p-limit": "^6.2.0",
"remark-parse": "^11.0.0",
"remark-stringify": "^11.0.0",
"resolve-from": "^5.0.0",
Expand All @@ -87,7 +88,7 @@
"yaml": "^2.7.1"
},
"devDependencies": {
"@1stg/common-config": "^11.1.1",
"@1stg/common-config": "^11.1.2",
"@changesets/changelog-github": "^0.5.1",
"@changesets/cli": "^2.28.1",
"@commitlint/cli": "^19.8.0",
Expand All @@ -100,7 +101,6 @@
"eslint": "^9.23.0",
"lint-staged": "^15.5.0",
"npm-run-all2": "^7.0.2",
"p-limit": "^6.2.0",
"prettier": "^3.5.3",
"simple-git-hooks": "^2.12.1",
"size-limit": "^11.2.0",
Expand Down
4 changes: 3 additions & 1 deletion src/comment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ import { getUsername, HTTP_STATUS_NOT_FOUND, TRUTHY_VALUES } from './utils.js'
const generatedByBotNote = 'Generated By Changesets GitLab Bot'

const getReleasePlanMessage = (releasePlan: ReleasePlan | null) => {
if (!releasePlan) return ''
if (!releasePlan) {
return ''
}

const publishableReleases = releasePlan.releases.filter(
(x): x is ComprehensiveRelease & { type: Exclude<VersionType, 'none'> } =>
Expand Down
Loading
Loading