[vLLM] Use wheels from partially-failed nightly runs - #7881
Open
whitneywhtsang wants to merge 1 commit into
Open
[vLLM] Use wheels from partially-failed nightly runs#7881whitneywhtsang wants to merge 1 commit into
whitneywhtsang wants to merge 1 commit into
Conversation
The install-vllm.sh script was filtering nightly runs by `conclusion=="success"`, which excluded runs where Python 3.15 failed but Python 3.10-3.12 vLLM wheels were successfully built and uploaded. This caused the script to fall back to the last fully successful run from 2026-08-27, resulting in a commit mismatch error when the pin was updated to baaa05bb in PR #7832. Change the logic to try two runs in order: 1. Latest run (any conclusion) - handles partial failures 2. Latest successful run - fallback for genuine failures This allows using wheels from runs where only some Python versions fail (e.g., Python 3.15 beta instability) while keeping a safe fallback. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install-vllm.sh script was filtering nightly runs by
conclusion=="success", which excluded runs where Python 3.15 failed but Python 3.10-3.12 vLLM wheels were successfully built and uploaded.This caused the script to fall back to the last fully successful run, resulting in a commit mismatch error when the pin was updated.
Change the logic to try two runs in order:
This allows using wheels from runs where only some Python versions fail (e.g., Python 3.15 beta instability) while keeping a safe fallback.