[CI][benchmarks] Option to run all liger tests #3917
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-penkin
requested changes
Apr 14, 2025
| @@ -89,11 +93,21 @@ jobs: | |||
| - name: Run Liger-Kernel tests | |||
| if: ${{ steps.install.outcome == 'success' && !cancelled() }} | |||
| run: | | |||
| pip install transformers pandas pytest | |||
| pip install transformers pandas pytest pillow | |||
There was a problem hiding this comment.
Let's remove this line, direct pytest call below and do a proper integration with test-triton.sh like it is done here:
| -e 's/,\s*pytest\.mark\.skipif(device="xpu", reason="skip for XPU")//g' \ | ||
| -e 's/pytest\.mark\.skipif(device="xpu", reason="skip for XPU"),\s*//g' \ | ||
| {} + | ||
| fi |
There was a problem hiding this comment.
Let's use the same unskip approach as we do for Triton UT's:
|
@Egor-Krivov ping. Can you address the review comments at your earlies convenience pls? |
Sure. I'm out of office right now and will only be able to get back to this issue on the 6th of May. |
auto-merge was automatically disabled
April 29, 2025 20:47
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to runn all tests from Liger-Kernels, including marked for skipping. Useful to check all cases.
For #3237