[GenAI Connectors] Resolves missing dashboard link in edit tab #221209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
the
release_note:skip
stephmilovic
added
the
Team: SecuritySolution
stephmilovic
added
Team:Security Generative AI
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
ymao1
approved these changes
May 22, 2025
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
Response Ops changes LGTM. Code review only.
angorayc
approved these changes
May 22, 2025
x-pack/platform/plugins/shared/actions/server/lib/gen_ai_token_tracking.ts
Show resolved
Hide resolved
x-pack/platform/plugins/shared/actions/server/lib/gen_ai_token_tracking.test.ts
Outdated
Show resolved
Hide resolved
…_tracking.test.ts Co-authored-by: Angela Chuang <[email protected]>
…ovic/kibana into genai_connector_dashboard_fixes
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
May 22, 2025
…ic#221209) (cherry picked from commit 5623f65) # Conflicts: # x-pack/platform/plugins/shared/triggers_actions_ui/public/plugin.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
stephmilovic
added a commit
that referenced
this pull request
May 27, 2025
…#221209) (#221287) # Backport This will backport the following commits from `main` to `8.19`: - [[GenAI Connectors] Resolves missing dashboard link in edit tab (#221209)](#221209) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-22T16:15:32Z","message":"[GenAI Connectors] Resolves missing dashboard link in edit tab (#221209)","sha":"5623f654aa8bdb11eff5c0b9f4a3c7dff2aba8c4","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0"],"title":"[GenAI Connectors] Resolves missing dashboard link in edit tab","number":221209,"url":"https://github.com/elastic/kibana/pull/221209","mergeCommit":{"message":"[GenAI Connectors] Resolves missing dashboard link in edit tab (#221209)","sha":"5623f654aa8bdb11eff5c0b9f4a3c7dff2aba8c4"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221209","number":221209,"mergeCommit":{"message":"[GenAI Connectors] Resolves missing dashboard link in edit tab (#221209)","sha":"5623f654aa8bdb11eff5c0b9f4a3c7dff2aba8c4"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was noticing some issues around the dashboard link in GenAI connectors. It was not appearing in the connector edit view. Additionally, when some connector types tried to get token telemetry off of the
getDashboardsubaction resulting in an error:Error log resolution
I resolved the error log by adding a check to skip token telemetry if the action is
getDashboardas this action never invokes a model.Missing link resolution
I noticed that this line hand changed from
dashboard.locatorto use something called theshareservice in this PR: #212968. It seems that the share plugin was not properly initialized intriger_actions_ui/public/plugin.ts, so I added it there and this fixed the issue with the dashboard link missing.To test
Response did not contain usage objectno longer appears