Skip to content

[8.19] [GenAI Connectors] Resolves missing dashboard link in edit tab (#221209) #221287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephmilovic merged 4 commits into from
May 27, 2025
Merged

[8.19] [GenAI Connectors] Resolves missing dashboard link in edit tab (#221209) #221287

stephmilovic merged 4 commits into from
May 27, 2025

Conversation

@stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented May 22, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@stephmilovic
[GenAI Connectors] Resolves missing dashboard link in edit tab (elast…
63df4c9 
…ic#221209)

(cherry picked from commit 5623f65)

# Conflicts:
#	x-pack/platform/plugins/shared/triggers_actions_ui/public/plugin.ts
@stephmilovic stephmilovic added the backport This PR is a backport of another PR label May 22, 2025
@stephmilovic stephmilovic enabled auto-merge (squash) May 22, 2025 16:24
@stephmilovic stephmilovic mentioned this pull request May 22, 2025
Merged
@mgiota
Copy link
Contributor

mgiota commented May 26, 2025 •
edited
Loading

@stephmilovic My PR was merged last week and it looks like backport PR has failed.

Screenshot 2025-05-26 at 11 52 45

So I guess your backport PR should first be merged before I try to manually backport my PR, right? What's the status of this PR?

mgiota
mgiota approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephmilovic
Copy link
Contributor Author

stephmilovic commented May 27, 2025

@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 8345920 into elastic:8.19 May 27, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented May 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / CustomFields renders correctly
  • [job] [logs] FTR Configs #1 / Synthetics API Tests SyncGlobalParams parsed params for previously added http monitors

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 618.1KB 618.3KB +144.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 108.1KB 108.1KB +28.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgiota mgiota mgiota approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephmilovic @mgiota @elasticmachine