revert back to go1.23 and pin cri-tool to v1.32.0 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Mahmoud <[email protected]>
msherif1234
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
===========================================
+ Coverage 32.28% 43.12% +10.83%
===========================================
Files 67 67
Lines 8018 8018
===========================================
+ Hits 2589 3458 +869
+ Misses 5196 4295 -901
- Partials 233 265 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Billy99
reviewed
Mar 18, 2025
There was a problem hiding this comment.
/lgtm
@anfredette I think you added cri-tools dependency, assume you are good with pining it?
msherif1234
pushed a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Apr 10, 2025
…s/component-update-ocp-bpfman-agent chore(deps): update ocp-bpfman-agent to 8879c86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR we have to pin cri-tool to version
v1.32.0to avoid bump to go1.24