Skip to content

Conversation

@frobware
Copy link
Contributor

@frobware frobware commented May 8, 2025

This reverts #416.

Downstream is now using Go 1.24.

The revert will also switch back CRI_REPO_BRANCH=master.

frobware added 2 commits May 8, 2025 17:03
Signed-off-by: Andrew McDermott <[email protected]>
@frobware frobware force-pushed the revert-the-revert-1.24 branch from 909acf7 to 811d008 Compare May 8, 2025 16:03
@frobware
Copy link
Contributor Author

frobware commented May 8, 2025

I end up typing /override ci/prow/test-fmt in every downstream PR so the switch to Go 1.24 would make it easier to auto merge those downstream PRs.

@msherif1234
Copy link
Contributor

interesting I did ask them if 4.19 can switch to go1.24 and the answer was no :)

WORKDIR /usr/src/cri-tools
ARG CRI_REPO_URL=https://github.com/kubernetes-sigs/cri-tools
ARG CRI_REPO_TAG=v1.32.0
ARG CRI_REPO_BRANCH=master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u pls see if they have released new version so we can use it as new pinned tag instead of master ?

@frobware
Copy link
Contributor Author

frobware commented May 9, 2025

interesting I did ask them if 4.19 can switch to go1.24 and the answer was no :)

Hmm. Maybe this is because we've branched for 4.20 and Go 1.24 is OK for 4.20.

/hold

@msherif1234
Copy link
Contributor

@dave-tucker was added to my internal slack thread you can get added and check the plans for 4.19 maybe things changed ?

ralphbean pushed a commit to ralphbean/bpfman-operator that referenced this pull request Jun 10, 2025
…s/component-update-ocp-bpfman-agent

chore(deps): update ocp-bpfman-agent to a7be28e
Copy link
Contributor

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit 0940d78 into bpfman:main Jul 1, 2025
14 checks passed
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0b6fa45) to head (811d008).
Report is 17 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #439   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frobware frobware deleted the revert-the-revert-1.24 branch September 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants