-
Notifications
You must be signed in to change notification settings - Fork 24
Switch to Go 1.24 (again) #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 39d118e. Signed-off-by: Andrew McDermott <[email protected]>
Signed-off-by: Andrew McDermott <[email protected]>
909acf7 to
811d008
Compare
|
I end up typing |
|
interesting I did ask them if 4.19 can switch to go1.24 and the answer was no :) |
| WORKDIR /usr/src/cri-tools | ||
| ARG CRI_REPO_URL=https://github.com/kubernetes-sigs/cri-tools | ||
| ARG CRI_REPO_TAG=v1.32.0 | ||
| ARG CRI_REPO_BRANCH=master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u pls see if they have released new version so we can use it as new pinned tag instead of master ?
Hmm. Maybe this is because we've branched for 4.20 and Go 1.24 is OK for 4.20. /hold |
|
@dave-tucker was added to my internal slack thread you can get added and check the plans for 4.19 maybe things changed ? |
…s/component-update-ocp-bpfman-agent chore(deps): update ocp-bpfman-agent to a7be28e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts #416.
Downstream is now using Go 1.24.
The revert will also switch back
CRI_REPO_BRANCH=master.