Skip to content

Commit 7377aa5

Browse files
authored
Merge pull request #416 from msherif1234/crti-tools
revert back to go1.23 and pin cri-tool to v1.32.0
2 parents 782b865 + 39d118e commit 7377aa5

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

.github/workflows/integration_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-24.04
1414
strategy:
1515
matrix:
16-
go: ["1.24"]
16+
go: ["1.23"]
1717
oci_bin: ["docker", "podman"]
1818
env:
1919
BPFMAN_AGENT_IMG: quay.io/bpfman/bpfman-agent:int-test

.github/workflows/pull_request.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
go: ["1.24"]
23+
go: ["1.23"]
2424
arch:
2525
- arch: amd64
2626
filename: linux-x86_64
@@ -59,7 +59,7 @@ jobs:
5959
run: make test
6060

6161
- name: Archive Go code coverage results
62-
if: ${{ matrix.arch.arch == 'amd64' && matrix.go == '1.24' }}
62+
if: ${{ matrix.arch.arch == 'amd64' && matrix.go == '1.23' }}
6363
uses: actions/upload-artifact@v4
6464
with:
6565
name: coverage-go

Containerfile.bpfman-agent

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Build the manager binary
22
ARG BUILDPLATFORM
33

4-
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.24 AS bpfman-agent-build
4+
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.23 AS bpfman-agent-build
55

66
# The following ARGs are set internally by docker/build-push-action in github actions
77
ARG TARGETOS
@@ -25,7 +25,7 @@ COPY . .
2525
RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -mod vendor -o bpfman-agent ./cmd/bpfman-agent/main.go
2626

2727

28-
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.24 AS cri-tools-build
28+
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.23 AS cri-tools-build
2929
# The following ARGs are set internally by docker/build-push-action in github actions
3030
ARG TARGETOS
3131
ARG TARGETARCH
@@ -37,12 +37,12 @@ RUN echo "TARGETOS=${TARGETOS} TARGETARCH=${TARGETARCH} BUILDPLATFORM=${BUILDP
3737

3838
WORKDIR /usr/src/cri-tools
3939
ARG CRI_REPO_URL=https://github.com/kubernetes-sigs/cri-tools
40-
ARG CRI_REPO_BRANCH=master
40+
ARG CRI_REPO_TAG=v1.32.0
4141

42-
RUN git clone --depth 1 --branch $CRI_REPO_BRANCH $CRI_REPO_URL .
42+
RUN git clone --depth 1 --branch $CRI_REPO_TAG $CRI_REPO_URL .
4343

4444
# Build
45-
RUN GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} VERSION="latest" make
45+
RUN GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} VERSION=$CRI_REPO_TAG make
4646
RUN cp ./build/bin/${TARGETOS}/${TARGETARCH}/crictl .
4747

4848
# Use the fedora minimal image to reduce the size of the final image but still

Containerfile.bpfman-operator

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Build the manager binary
22
ARG BUILDPLATFORM
33

4-
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.24 AS bpfman-operator-build
4+
FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.23 AS bpfman-operator-build
55

66
ARG BUILDPLATFORM
77

go.mod

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
module github.com/bpfman/bpfman-operator
22

3-
go 1.24.0
3+
go 1.23.0
4+
5+
toolchain go1.23.5
46

57
require (
68
github.com/bpfman/bpfman v0.5.7-0.20250305151919-a74c631c3643
@@ -16,7 +18,6 @@ require (
1618
k8s.io/client-go v0.32.2
1719
k8s.io/code-generator v0.32.2
1820
sigs.k8s.io/controller-runtime v0.20.2
19-
sigs.k8s.io/yaml v1.4.0
2021
)
2122

2223
require (
@@ -32,6 +33,7 @@ require (
3233
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
3334
k8s.io/gengo/v2 v2.0.0-20240911193312-2b36238f13e9 // indirect
3435
sigs.k8s.io/gateway-api v1.1.0 // indirect
36+
sigs.k8s.io/yaml v1.4.0 // indirect
3537
)
3638

3739
require (

0 commit comments

Comments
 (0)