Skip to content

Remove unused dependencies #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Remove unused dependencies #297

merged 2 commits into from
Jun 2, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 2, 2025

🎟️ Tracking

📔 Objective

Cleanup deps, and fix compilation issues with certain flag combinations using cargo hack.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner June 2, 2025 10:45
@Hinton Hinton requested a review from dani-garcia June 2, 2025 10:45
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Logo
Checkmarx One – Scan Summary & Details50541d95-1bfc-4f5a-9707-b45ef825e3a6

Great job, no security vulnerabilities found in this Pull Request

Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.32%. Comparing base (fc80849) to head (2f04ceb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   70.28%   70.32%   +0.03%     
==========================================
  Files         217      217              
  Lines       16990    16990              
==========================================
+ Hits        11942    11948       +6     
+ Misses       5048     5042       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, feature flag unification in the workspace, what a pain

@Hinton Hinton merged commit 4bb596a into main Jun 2, 2025
43 checks passed
@Hinton Hinton deleted the cleanup-deps branch June 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants