Skip to content

Remove unused dependencies #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions crates/bitwarden-core/src/auth/login/password.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ use serde::{Deserialize, Serialize};

use crate::auth::{
api::response::IdentityTokenResponse,
login::{
response::{captcha_response::CaptchaResponse, two_factor::TwoFactorProviders},
LoginError,
},
login::response::{captcha_response::CaptchaResponse, two_factor::TwoFactorProviders},
};
#[cfg(feature = "internal")]
use crate::{
auth::{api::request::PasswordTokenRequest, login::TwoFactorRequest},
auth::{api::request::PasswordTokenRequest, login::LoginError, login::TwoFactorRequest},
client::LoginMethod,
Client,
};
Expand Down
16 changes: 9 additions & 7 deletions crates/bitwarden-core/src/client/encryption_settings.rs
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
use bitwarden_crypto::{AsymmetricCryptoKey, KeyStore, SymmetricCryptoKey};
#[cfg(feature = "internal")]
use bitwarden_crypto::{EncString, UnsignedSharedKey};
use bitwarden_crypto::{AsymmetricCryptoKey, EncString, UnsignedSharedKey};
#[cfg(any(feature = "internal", feature = "secrets"))]
use bitwarden_crypto::{KeyStore, SymmetricCryptoKey};
use bitwarden_error::bitwarden_error;
use thiserror::Error;
#[cfg(any(feature = "internal", feature = "secrets"))]
use uuid::Uuid;

use crate::{
error::UserIdAlreadySetError,
key_management::{AsymmetricKeyId, KeyIds, SymmetricKeyId},
MissingPrivateKeyError, VaultLockedError,
};
#[cfg(feature = "internal")]
use crate::key_management::AsymmetricKeyId;
#[cfg(any(feature = "internal", feature = "secrets"))]
use crate::key_management::{KeyIds, SymmetricKeyId};
use crate::{error::UserIdAlreadySetError, MissingPrivateKeyError, VaultLockedError};

#[bitwarden_error(flat)]
#[derive(Debug, Error)]
Expand Down
9 changes: 4 additions & 5 deletions crates/bitwarden-core/src/client/internal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ use uuid::Uuid;

#[cfg(feature = "secrets")]
use super::login_method::ServiceAccountLoginMethod;
#[cfg(any(feature = "internal", feature = "secrets"))]
use crate::client::encryption_settings::EncryptionSettings;
use crate::{
auth::renew::renew_token,
client::{encryption_settings::EncryptionSettings, login_method::LoginMethod},
error::UserIdAlreadySetError,
key_management::KeyIds,
DeviceType,
auth::renew::renew_token, client::login_method::LoginMethod, error::UserIdAlreadySetError,
key_management::KeyIds, DeviceType,
};
#[cfg(feature = "internal")]
use crate::{
Expand Down
9 changes: 5 additions & 4 deletions crates/bitwarden-exporters/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ keywords.workspace = true

[features]
uniffi = ["dep:uniffi", "bitwarden-core/uniffi"] # Uniffi bindings
wasm = ["dep:tsify-next", "dep:wasm-bindgen"] # WebAssembly bindings
wasm = [
"bitwarden-vault/wasm",
"dep:tsify-next",
"dep:wasm-bindgen"
] # WebAssembly bindings

[dependencies]
base64 = ">=0.22.1, <0.23"
Expand All @@ -38,8 +42,5 @@ uniffi = { workspace = true, optional = true }
uuid = { workspace = true }
wasm-bindgen = { workspace = true, optional = true }

[dev-dependencies]
rand = ">=0.8.5, <0.9"

[lints]
workspace = true
6 changes: 5 additions & 1 deletion crates/bitwarden-generators/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ keywords.workspace = true

[features]
uniffi = ["dep:uniffi"] # Uniffi bindings
wasm = ["dep:tsify-next", "dep:wasm-bindgen"]
wasm = [
"bitwarden-core/wasm",
"dep:tsify-next",
"dep:wasm-bindgen"
] # WebAssembly bindings

[dependencies]
bitwarden-core = { workspace = true, features = ["internal"] }
Expand Down
1 change: 0 additions & 1 deletion crates/bitwarden-send/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ serde_repr = { workspace = true }
thiserror = { workspace = true }
uniffi = { workspace = true, optional = true }
uuid = { workspace = true }
wasm-bindgen = { workspace = true, optional = true }
zeroize = { version = ">=1.7.0, <2.0" }

[lints]
Expand Down
1 change: 0 additions & 1 deletion crates/bitwarden-threading/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ keywords.workspace = true
bitwarden-error = { workspace = true }
log = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
thiserror = { workspace = true }
tokio = { features = ["sync", "time", "rt"], workspace = true }
tokio-util = { version = "0.7.15" }
Expand Down
1 change: 0 additions & 1 deletion crates/bitwarden-uniffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ bitwarden-vault = { workspace = true, features = ["uniffi"] }
chrono = { workspace = true, features = ["std"] }
env_logger = "0.11.1"
log = { workspace = true }
schemars = { workspace = true, optional = true }
thiserror = { workspace = true }
uniffi = { workspace = true }
uuid = { workspace = true }
Expand Down
1 change: 0 additions & 1 deletion crates/bitwarden-uuid-macro/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ license-file.workspace = true
keywords.workspace = true

[dependencies]
proc-macro2 = { workspace = true }
quote = { workspace = true }
syn = { workspace = true }

Expand Down
7 changes: 5 additions & 2 deletions crates/bitwarden-vault/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ uniffi = [
"bitwarden-crypto/uniffi",
"dep:uniffi"
] # Uniffi bindings
wasm = ["dep:tsify-next", "dep:wasm-bindgen"] # WASM support
wasm = [
"bitwarden-core/wasm",
"dep:tsify-next",
"dep:wasm-bindgen"
] # WASM support

[dependencies]
base64 = ">=0.22.1, <0.23"
Expand All @@ -32,7 +36,6 @@ chrono = { workspace = true }
data-encoding = ">=2.0, <3"
hmac = ">=0.12.1, <0.13"
percent-encoding = ">=2.1, <3.0"
rand = ">=0.8.5, <0.9"
reqwest = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
Expand Down
3 changes: 0 additions & 3 deletions crates/bitwarden-wasm-internal/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@ bitwarden-generators = { workspace = true, features = ["wasm"] }
bitwarden-ipc = { workspace = true, features = ["wasm"] }
bitwarden-ssh = { workspace = true, features = ["wasm"] }
bitwarden-vault = { workspace = true, features = ["wasm"] }
chrono = { workspace = true }
console_error_panic_hook = "0.1.7"
console_log = { version = "1.0.0", features = ["color"] }
js-sys = "0.3.68"
log = "0.4.20"
serde_json = ">=1.0.96, <2.0"
# When upgrading wasm-bindgen, make sure to update the version in the workflows!
wasm-bindgen = { version = "=0.2.100", features = ["serde-serialize"] }
wasm-bindgen-futures = "0.4.41"
Expand Down
1 change: 0 additions & 1 deletion crates/bw/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ license-file.workspace = true
[dependencies]
bitwarden-cli = { workspace = true }
bitwarden-core = { workspace = true }
bitwarden-crypto = { workspace = true }
bitwarden-generators = { workspace = true }
bitwarden-vault = { workspace = true }
clap = { version = "4.5.4", features = ["derive", "env"] }
Expand Down
Loading