Remove unused dependencies (#297)

Cleanup deps, and fix compilation issues with certain flag combinations
using cargo hack.

Author: Hinton

Cargo.lock

@@ -7,14 +7,11 @@ use serde::{Deserialize, Serialize};
 
 use crate::auth::{
     api::response::IdentityTokenResponse,
-    login::{
-        response::{captcha_response::CaptchaResponse, two_factor::TwoFactorProviders},
-        LoginError,
-    },
+    login::response::{captcha_response::CaptchaResponse, two_factor::TwoFactorProviders},
 };
 #[cfg(feature = "internal")]
 use crate::{
-    auth::{api::request::PasswordTokenRequest, login::TwoFactorRequest},
+    auth::{api::request::PasswordTokenRequest, login::LoginError, login::TwoFactorRequest},
     client::LoginMethod,
     Client,
 };

crates/bitwarden-core/src/auth/login/password.rs

@@ -1,15 +1,17 @@
-use bitwarden_crypto::{AsymmetricCryptoKey, KeyStore, SymmetricCryptoKey};
 #[cfg(feature = "internal")]
-use bitwarden_crypto::{EncString, UnsignedSharedKey};
+use bitwarden_crypto::{AsymmetricCryptoKey, EncString, UnsignedSharedKey};
+#[cfg(any(feature = "internal", feature = "secrets"))]
+use bitwarden_crypto::{KeyStore, SymmetricCryptoKey};
 use bitwarden_error::bitwarden_error;
 use thiserror::Error;
+#[cfg(any(feature = "internal", feature = "secrets"))]
 use uuid::Uuid;
 
-use crate::{
-    error::UserIdAlreadySetError,
-    key_management::{AsymmetricKeyId, KeyIds, SymmetricKeyId},
-    MissingPrivateKeyError, VaultLockedError,
-};
+#[cfg(feature = "internal")]
+use crate::key_management::AsymmetricKeyId;
+#[cfg(any(feature = "internal", feature = "secrets"))]
+use crate::key_management::{KeyIds, SymmetricKeyId};
+use crate::{error::UserIdAlreadySetError, MissingPrivateKeyError, VaultLockedError};
 
 #[bitwarden_error(flat)]
 #[derive(Debug, Error)]

crates/bitwarden-core/src/client/encryption_settings.rs

@@ -10,12 +10,11 @@ use uuid::Uuid;
 
 #[cfg(feature = "secrets")]
 use super::login_method::ServiceAccountLoginMethod;
+#[cfg(any(feature = "internal", feature = "secrets"))]
+use crate::client::encryption_settings::EncryptionSettings;
 use crate::{
-    auth::renew::renew_token,
-    client::{encryption_settings::EncryptionSettings, login_method::LoginMethod},
-    error::UserIdAlreadySetError,
-    key_management::KeyIds,
-    DeviceType,
+    auth::renew::renew_token, client::login_method::LoginMethod, error::UserIdAlreadySetError,
+    key_management::KeyIds, DeviceType,
 };
 #[cfg(feature = "internal")]
 use crate::{

crates/bitwarden-core/src/client/internal.rs

@@ -17,7 +17,11 @@ keywords.workspace = true
 
 [features]
 uniffi = ["dep:uniffi", "bitwarden-core/uniffi"] # Uniffi bindings
-wasm = ["dep:tsify-next", "dep:wasm-bindgen"]    # WebAssembly bindings
+wasm = [
+    "bitwarden-vault/wasm",
+    "dep:tsify-next",
+    "dep:wasm-bindgen"
+] # WebAssembly bindings
 
 [dependencies]
 base64 = ">=0.22.1, <0.23"
@@ -38,8 +42,5 @@ uniffi = { workspace = true, optional = true }
 uuid = { workspace = true }
 wasm-bindgen = { workspace = true, optional = true }
 
-[dev-dependencies]
-rand = ">=0.8.5, <0.9"
-
 [lints]
 workspace = true

crates/bitwarden-exporters/Cargo.toml

@@ -16,7 +16,11 @@ keywords.workspace = true
 
 [features]
 uniffi = ["dep:uniffi"] # Uniffi bindings
-wasm = ["dep:tsify-next", "dep:wasm-bindgen"]
+wasm = [
+    "bitwarden-core/wasm",
+    "dep:tsify-next",
+    "dep:wasm-bindgen"
+] # WebAssembly bindings
 
 [dependencies]
 bitwarden-core = { workspace = true, features = ["internal"] }

crates/bitwarden-generators/Cargo.toml

@@ -32,7 +32,6 @@ serde_repr = { workspace = true }
 thiserror = { workspace = true }
 uniffi = { workspace = true, optional = true }
 uuid = { workspace = true }
-wasm-bindgen = { workspace = true, optional = true }
 zeroize = { version = ">=1.7.0, <2.0" }
 
 [lints]

crates/bitwarden-send/Cargo.toml

@@ -13,7 +13,6 @@ keywords.workspace = true
 bitwarden-error = { workspace = true }
 log = { workspace = true }
 serde = { workspace = true }
-serde_json = { workspace = true }
 thiserror = { workspace = true }
 tokio = { features = ["sync", "time", "rt"], workspace = true }
 tokio-util = { version = "0.7.15" }

crates/bitwarden-threading/Cargo.toml

@@ -31,7 +31,6 @@ bitwarden-vault = { workspace = true, features = ["uniffi"] }
 chrono = { workspace = true, features = ["std"] }
 env_logger = "0.11.1"
 log = { workspace = true }
-schemars = { workspace = true, optional = true }
 thiserror = { workspace = true }
 uniffi = { workspace = true }
 uuid = { workspace = true }

crates/bitwarden-uniffi/Cargo.toml

@@ -15,7 +15,6 @@ license-file.workspace = true
 keywords.workspace = true
 
 [dependencies]
-proc-macro2 = { workspace = true }
 quote = { workspace = true }
 syn = { workspace = true }
 

crates/bitwarden-uuid-macro/Cargo.toml

@@ -20,7 +20,11 @@ uniffi = [
     "bitwarden-crypto/uniffi",
     "dep:uniffi"
 ] # Uniffi bindings
-wasm = ["dep:tsify-next", "dep:wasm-bindgen"] # WASM support
+wasm = [
+    "bitwarden-core/wasm",
+    "dep:tsify-next",
+    "dep:wasm-bindgen"
+] # WASM support
 
 [dependencies]
 base64 = ">=0.22.1, <0.23"
@@ -32,7 +36,6 @@ chrono = { workspace = true }
 data-encoding = ">=2.0, <3"
 hmac = ">=0.12.1, <0.13"
 percent-encoding = ">=2.1, <3.0"
-rand = ">=0.8.5, <0.9"
 reqwest = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }

crates/bitwarden-vault/Cargo.toml

@@ -24,12 +24,9 @@ bitwarden-generators = { workspace = true, features = ["wasm"] }
 bitwarden-ipc = { workspace = true, features = ["wasm"] }
 bitwarden-ssh = { workspace = true, features = ["wasm"] }
 bitwarden-vault = { workspace = true, features = ["wasm"] }
-chrono = { workspace = true }
 console_error_panic_hook = "0.1.7"
 console_log = { version = "1.0.0", features = ["color"] }
-js-sys = "0.3.68"
 log = "0.4.20"
-serde_json = ">=1.0.96, <2.0"
 # When upgrading wasm-bindgen, make sure to update the version in the workflows!
 wasm-bindgen = { version = "=0.2.100", features = ["serde-serialize"] }
 wasm-bindgen-futures = "0.4.41"

crates/bitwarden-wasm-internal/Cargo.toml

@@ -17,7 +17,6 @@ license-file.workspace = true
 [dependencies]
 bitwarden-cli = { workspace = true }
 bitwarden-core = { workspace = true }
-bitwarden-crypto = { workspace = true }
 bitwarden-generators = { workspace = true }
 bitwarden-vault = { workspace = true }
 clap = { version = "4.5.4", features = ["derive", "env"] }