Skip to content

[VEG-1404] Bump the version for deployment #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etanxing merged 1 commit into from
Aug 8, 2022
Merged

[VEG-1404] Bump the version for deployment #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zendesk_app_framework_sdk",
"version": "2.0.37",
"version": "2.0.36",
Copy link
Contributor

@zidmus zidmus Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was 37 should be bumped top 38?

Copy link
Contributor Author

@etanxing etanxing Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest is v2.0.36 which already has #172 and #174. It was v2.0.33 and changed to v2.0.37 by accident.

Copy link

@token-cjg token-cjg Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a process to properly bump the version when we tag zaf_sdk as part of the deployment process.

Maybe we might be able to emulate the way deployments are currently done for gems? This might be worth asking the appropriate internal team about to see if they have plans for a github action along these lines.

"main": "build/zaf_sdk.min.js",
"description": "The Zendesk App Framework (ZAF) SDK is a JavaScript library that simplifies cross-frame communication between iframed apps and ZAF.",
"homepage": "http://developer.zendesk.com",
Expand Down