Skip to content

Conversation

@etanxing
Copy link
Contributor

@etanxing etanxing commented Aug 8, 2022

✌️

/cc @zendesk/vegemite

Description

Bump the correct version. f072478 was pushed by accident.

Tasks

  • Include comments/inline docs where appropriate
  • Add unit tests
  • Update changelog here

References

DevQA Steps

NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.

Risks

  • [HIGH | medium | low] Does it work across browsers (including IE!)?
  • [HIGH | medium | low] Does it work in the different products (Support, Chat, Connect)?
  • [HIGH | medium | low] Are there any performance implications?
  • [HIGH | medium | low] Any security risks?
  • [HIGH | medium | low] What features does this touch?

Rollback Plan

  1. Quickly roll back to the prior release so that customers can refresh to resolve their issue.
  2. Revert this PR to restore the master branch to a deployable green state.
  3. Notify the author.

@etanxing etanxing marked this pull request as ready for review August 8, 2022 00:36
@etanxing etanxing requested a review from a team August 8, 2022 00:38
{
"name": "zendesk_app_framework_sdk",
"version": "2.0.37",
"version": "2.0.36",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was 37 should be bumped top 38?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest is v2.0.36 which already has #172 and #174. It was v2.0.33 and changed to v2.0.37 by accident.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a process to properly bump the version when we tag zaf_sdk as part of the deployment process.

Maybe we might be able to emulate the way deployments are currently done for gems? This might be worth asking the appropriate internal team about to see if they have plans for a github action along these lines.

@etanxing etanxing merged commit 3ce8835 into master Aug 8, 2022
@zendesk-deploy
Copy link

This PR was deployed to Static Assets Build. Reference: v2.0.37

@zendesk-deploy
Copy link

This PR was deployed to Static Assets Switch Staging. Reference: v2.0.37

@zendesk-deploy
Copy link

This PR was deployed to Static Assets Switch Major (v2). Reference: v2.0.37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants