[VEG-1404] Enable ZAF SDK to be imported as a Node Module #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
We're going to enable ZAF SDK to be imported as a Node Module. PR #144 was previously raised, all points make sense.
Since we introduced Typescript we can't import
lib/index.jsdirectly. Instead, importdist/zaf_sdk.min.jswhich are the assets for npm publish.If you want to install from github,
npm install https://github.com/zendesk/zendesk_app_framework_sdk#"wxing/VEG-1404" --save.Make sure to commit the latest
distbynpm run buildeach time. Once we move to npm, it can be done via CI/CD.Tasks
References
DevQA Steps
NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.
Risks
Rollback Plan