-
Notifications
You must be signed in to change notification settings - Fork 255
Add short representation generator for MeasureUnit #6685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f859992
Add short representation generation for MeasureUnit
younies be39cd3
fix clippy
younies 9345a38
continue fixing clippy
younies 34ab326
Fix the short representation to be more concise
younies ba8bdad
Refactor short representation methods for MeasureUnit, SiPrefix, and …
younies ead9c1f
Merge branch 'main' into generate_id
younies 35a29db
Merge branch 'main' into generate_id
younies b59b0b3
Fix
younies dd87964
change naming
younies b0c6d89
use write!
younies f6a28a5
Update components/experimental/src/measure/measureunit.rs
younies acf0daa
Update components/experimental/src/measure/measureunit.rs
younies ca8051a
improve counting zeros
younies 710942a
Merge branch 'main' into generate_id
younies e695b02
concise code
younies 3959102
fix clippy
younies fa26e72
fix publicity
younies e4c5763
Merge branch 'main' into generate_id
younies b9719f4
fix doc
younies a3ccda1
fix infaillable
younies 45696f9
fix
younies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this actually intended to be a public API?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, yes. Once we start using it internally, it will be private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what requires this to be public now? I'm worried that this will be forgotten and accidentally made public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will needed in the data gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will you make it private if it's used in datagen? should it be in
provider?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have a field for the short unit id, but it is okay, the
fncan be public for now