Add short representation generator for MeasureUnit #6685

younies · 2025-06-19T14:56:46Z

Desctiption

Implemented generate_short_representation method in MeasureUnit to provide a concise string representation of measure units, including handling of constant denominators and scientific notation.
Added ToString implementation for SiPrefix and SingleUnit to facilitate their string representations, following a defined format for SI prefixes and unit IDs.
Updated documentation with examples for clarity on usage and expected outputs.

# Desctiption - Implemented `generate_short_representation` method in `MeasureUnit` to provide a concise string representation of measure units, including handling of constant denominators and scientific notation. - Added `ToString` implementation for `SiPrefix` and `SingleUnit` to facilitate their string representations, following a defined format for SI prefixes and unit IDs. - Updated documentation with examples for clarity on usage and expected outputs.

gemini-code-assist · 2025-06-19T14:56:50Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

components/experimental/src/measure/measureunit.rs

robertbastian · 2025-06-19T21:09:46Z

components/experimental/src/measure/measureunit.rs

+        // add constant part to the negative part
+        if self.constant_denominator > 0 {
+            if !negative_part.is_empty() {
+                negative_part.insert(0, '#');


do you need the #? C and R should be unambiguous without them

Sure, I was thinking about that. We only need C. In fact, we could even eliminate C if we declare the constant at the beginning, but let’s keep it for readability for now.

components/experimental/src/measure/provider/si_prefix.rs

components/experimental/src/measure/provider/single_unit.rs

components/experimental/src/measure/measureunit.rs

…SingleUnit - Updated `generate_short_representation` in `MeasureUnit` to utilize helper methods for appending short representations. - Introduced `append_short_representation` methods in `SiPrefix` and `SingleUnit` to streamline the process of generating their string representations. - Enhanced documentation with examples for better clarity on usage.

robertbastian · 2025-06-23T08:48:54Z

components/experimental/src/measure/measureunit.rs

-    ///
+    /// assert_eq!(short_representation, "C100I82P-1D3I85", "{}", "liter-per-100-kilometer");
    /// ```
    pub fn generate_short_representation(&self) -> String {


is this actually intended to be a public API?

For now, yes. Once we start using it internally, it will be private.

what requires this to be public now? I'm worried that this will be forgotten and accidentally made public

We will needed in the data gen

how will you make it private if it's used in datagen? should it be in provider?

we should have a field for the short unit id, but it is okay, the fn can be public for now

components/experimental/src/measure/measureunit.rs

components/experimental/src/measure/provider/si_prefix.rs

components/experimental/src/measure/provider/single_unit.rs

components/experimental/src/measure/measureunit.rs

robertbastian · 2025-06-23T14:18:40Z

components/experimental/src/measure/measureunit.rs

-    ///
+    /// assert_eq!(short_representation, "C100I82P-1D3I85", "{}", "liter-per-100-kilometer");
    /// ```
    pub fn generate_short_representation(&self) -> String {


what requires this to be public now? I'm worried that this will be forgotten and accidentally made public

components/experimental/src/measure/measureunit.rs

Co-authored-by: Robert Bastian <[email protected]>

robertbastian · 2025-06-24T08:52:44Z

components/experimental/src/measure/measureunit.rs

+            // Divide by 10^8
+            while n % 100_000_000 == 0 {
+                n /= 100_000_000;
+                zeros_count += 8;
+            }
+
+            // Divide by 10^4
+            while n % 10_000 == 0 {
+                n /= 10_000;
+                zeros_count += 4;
+            }
+
+            // Divide by 10^2
+            while n % 100 == 0 {
+                n /= 100;
+                zeros_count += 2;
+            }


what's the point of these? repeatedly dividing by 10 is sufficient

for reducing the time complexity

the time complexity is constant because the input is fixed-length. I don't think this is worth the additional code complexity

components/experimental/src/measure/provider/si_prefix.rs

components/experimental/src/measure/provider/single_unit.rs

robertbastian · 2025-07-03T13:41:21Z

components/experimental/src/measure/measureunit.rs

-    ///
+    /// assert_eq!(short_representation, "C100I82P-1D3I85", "{}", "liter-per-100-kilometer");
    /// ```
    pub fn generate_short_representation(&self) -> String {


how will you make it private if it's used in datagen? should it be in provider?

robertbastian · 2025-07-08T14:35:47Z

components/experimental/src/measure/provider/si_prefix.rs

+            Base::Decimal => 'D',
+            Base::Binary => 'B',
+        });
+        write!(buff, "{}", self.power).unwrap();


don't unwrap, it adds panicking code

also in other places

robertbastian

.

younies requested a review from a team as a code owner June 19, 2025 14:56

younies requested a review from robertbastian June 19, 2025 14:57

younies added 2 commits June 19, 2025 17:03

fix clippy

be39cd3

continue fixing clippy

9345a38

robertbastian reviewed Jun 19, 2025

View reviewed changes

younies added 3 commits June 20, 2025 16:12

Fix the short representation to be more concise

34ab326

Merge branch 'main' into generate_id

ead9c1f

younies requested a review from robertbastian June 20, 2025 15:38

younies closed this Jun 20, 2025

younies reopened this Jun 20, 2025

Merge branch 'main' into generate_id

35a29db

robertbastian reviewed Jun 23, 2025

View reviewed changes

younies added 3 commits June 23, 2025 15:38

Fix

b59b0b3

change naming

dd87964

use write!

b0c6d89

robertbastian reviewed Jun 23, 2025

View reviewed changes

younies requested a review from robertbastian June 23, 2025 21:02

younies and others added 3 commits June 24, 2025 10:00

Update components/experimental/src/measure/measureunit.rs

f6a28a5

Co-authored-by: Robert Bastian <[email protected]>

Update components/experimental/src/measure/measureunit.rs

acf0daa

Co-authored-by: Robert Bastian <[email protected]>

improve counting zeros

ca8051a

robertbastian reviewed Jun 30, 2025

View reviewed changes

younies added 2 commits July 3, 2025 13:36

Merge branch 'main' into generate_id

710942a

concise code

e695b02

younies requested a review from robertbastian July 3, 2025 11:42

fix clippy

3959102

robertbastian reviewed Jul 3, 2025

View reviewed changes

fix publicity

fa26e72

Merge branch 'main' into generate_id

e4c5763

younies requested a review from robertbastian July 8, 2025 14:08

fix doc

b9719f4

robertbastian reviewed Jul 8, 2025

View reviewed changes

fix infaillable

a3ccda1

younies requested a review from robertbastian July 8, 2025 15:09

robertbastian reviewed Jul 8, 2025

View reviewed changes

fix

45696f9

younies requested a review from robertbastian July 8, 2025 15:27

robertbastian approved these changes Jul 8, 2025

View reviewed changes

younies merged commit 6404bfd into unicode-org:main Jul 8, 2025
30 checks passed

younies deleted the generate_id branch July 8, 2025 15:43

Add short representation generator for MeasureUnit #6685

Add short representation generator for MeasureUnit #6685

Uh oh!

Conversation

younies commented Jun 19, 2025

Desctiption

Uh oh!

gemini-code-assist bot commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

younies Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

younies Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robertbastian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

younies Jun 23, 2025 •

edited

Loading

younies Jul 8, 2025 •

edited

Loading