Skip to content

Prometheus doc update #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: latest
Choose a base branch
from
Open

Prometheus doc update #4137

wants to merge 9 commits into from

Conversation

atovpeko
Copy link
Contributor

Add PostgreSQL procedure back for Cloud, clarify about labels

@github-actions GitHub Actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-revert-prometheus-docs

@atovpeko atovpeko mentioned this pull request May 22, 2025
Merged
@ramonguiu
Copy link
Contributor

@atovpeko any reason not to merge?

billy-the-fish
billy-the-fish approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits.

_partials/_prometheus-integrate.md
- targets: ['<exporter-host>:9187']
```

If `prometheus.yml` has not been created during installation, create it manually. If you are using Docker, you can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If prometheus.yml has not been created during installation, create it manually." seems pointless as you have just told them to do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're telling to update the file, but there is a possibility it hasn't been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahilsondhi rahilsondhi rahilsondhi approved these changes

@billy-the-fish billy-the-fish billy-the-fish approved these changes

@ramonguiu ramonguiu Awaiting requested review from ramonguiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atovpeko @ramonguiu @rahilsondhi @billy-the-fish