Skip to content

Run upgrade via dnf5 offline reboot#15

Merged
psss merged 2 commits intomainfrom
dnf5
Mar 23, 2026
Merged

Run upgrade via dnf5 offline reboot#15
psss merged 2 commits intomainfrom
dnf5

Conversation

@thrix
Copy link
Copy Markdown
Contributor

@thrix thrix commented Apr 22, 2025 •
edited by psss
Loading

Since fedora-42 the command dnf5 offline reboot is to be used for starting the upgrade.

thrix added a commit to teemtee/tmt that referenced this pull request Apr 22, 2025
@thrix
Update the upgrade test to use dnf5 offline reboot
5f294c0 
Seems `system-upgrade` does not work anymore, use the advised
`dnf5 offline reboot` to perform the upgrade from Fedora 42.

See teemtee/upgrade#15

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
thrix added a commit to teemtee/tmt that referenced this pull request Apr 22, 2025
@thrix
Update the upgrade test to use dnf5 offline reboot
992df30 
Seems `system-upgrade` does not work anymore, use the advised
`dnf5 offline reboot` to perform the upgrade from Fedora 42.

See teemtee/upgrade#15

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix thrix mentioned this pull request Apr 22, 2025
Merged
psss
psss approved these changes Apr 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@psss
Copy link
Copy Markdown
Member

psss commented Apr 22, 2025

@mmacura311, could you please have a look as well? Is this now the recommended way how to upgrade?

@psss psss requested a review from mmacura311 April 22, 2025 20:37
@mmacura311
Copy link
Copy Markdown
Collaborator

mmacura311 commented Apr 23, 2025

Hi @psss
according the documentation
https://docs.fedoraproject.org/en-US/quick-docs/upgrading-fedora-offline/
the user should run dnf system-upgrade download ... and afterwards dnf system-upgrade reboot so TBH I do not see a need to run the dnf5 offline which looks like lower-level functionality to perform offlne transactions.

@thrix
Copy link
Copy Markdown
Contributor Author

thrix commented Apr 23, 2025

Hi @psss according the documentation https://doI cs.fedoraproject.org/en-US/quick-docs/upgrading-fedora-offline/ the user should run dnf system-upgrade download ... and afterwards dnf system-upgrade reboot so TBH I do not see a need to run the dnf5 offline which looks like lower-level functionality to perform offlne transactions.

@mmacura311 yes, I conclude with you, unfortunately the dnf system-upgrade reboot for Fedora 41 to 42 upgrade does not actually trigger the update. Could be a bug, we do not know yet. Let's keep this open so we can eventually find out and move on unblocking tmt via this draft @psss .

@psss
Copy link
Copy Markdown
Member

psss commented Apr 23, 2025

Let's keep this open so we can eventually find out and move on unblocking tmt via this draft @psss .

Ack.

psss pushed a commit to teemtee/tmt that referenced this pull request Apr 23, 2025
@thrix @psss
Update the upgrade test to use dnf5 offline reboot
786f2d2 
Seems `system-upgrade` does not work anymore, use the advised
`dnf5 offline reboot` to perform the upgrade from Fedora 42.

See teemtee/upgrade#15

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
psss added a commit to teemtee/tmt that referenced this pull request Apr 23, 2025
@psss @thrix
Disable the virt-customize speed-up due to DNS issues (#3687)
3ded4e3 
The `virt-customize` for adding additional deps to the tested VM
image started to fail recently. Drop it for now until we find out
what is causing it to bring the test back to stable state.

Seems `system-upgrade` does not work anymore, use the advised
`dnf5 offline reboot` to perform the upgrade from Fedora 42.
See teemtee/upgrade#15

Add `beakerlib` framework for /tests/libraries/apache test
This is required if beakerlib is not bundled into the image.
Was dropped when workarounding tests for 1.47 release, see:
#3687

Co-authored-by: Miroslav Vadkerti <mvadkert@redhat.com>
@psss
Copy link
Copy Markdown
Member

psss commented Apr 23, 2025

See also the following pull request where packit targets were updated:

bajertom pushed a commit to teemtee/tmt that referenced this pull request Aug 11, 2025
@psss @thrix @bajertom
Disable the virt-customize speed-up due to DNS issues (#3687)
e7c041a 
The `virt-customize` for adding additional deps to the tested VM
image started to fail recently. Drop it for now until we find out
what is causing it to bring the test back to stable state.

Seems `system-upgrade` does not work anymore, use the advised
`dnf5 offline reboot` to perform the upgrade from Fedora 42.
See teemtee/upgrade#15

Add `beakerlib` framework for /tests/libraries/apache test
This is required if beakerlib is not bundled into the image.
Was dropped when workarounding tests for 1.47 release, see:
#3687

Co-authored-by: Miroslav Vadkerti <mvadkert@redhat.com>
@psss psss mentioned this pull request Mar 23, 2026
Merged
@thrix @psss
Run upgrade via dnf5 offline reboot for Fedora42+
7fccea6 
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@psss psss force-pushed the dnf5 branch 2 times, most recently from dbedb67 to 43cb7fc Compare March 23, 2026 14:45
@psss psss marked this pull request as ready for review March 23, 2026 14:50
@psss psss changed the title Run upgrade via dnf5 offline reboot for Fedora42+ Run upgrade via dnf5 offline reboot Mar 23, 2026
@psss psss added this to planning Mar 23, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 23, 2026
@psss psss merged commit c005151 into main Mar 23, 2026
@psss psss deleted the dnf5 branch March 23, 2026 15:19
@github-project-automation github-project-automation bot moved this from backlog to done in planning Mar 23, 2026
@psss psss mentioned this pull request Mar 23, 2026
Closed
@psss psss added the bug Something isn't working label Mar 23, 2026
@psss psss mentioned this pull request Mar 23, 2026
Merged
1 task
psss added a commit to teemtee/tmt that referenced this pull request Mar 23, 2026
@psss
Use a different package for upgrade dependency test (#4725)
94af565 
The `dummy-test-package-crested` package is no more maintained, let's
use a different one.

* Update require to use `tree` instead
* Rename `finish` to `cleanup` to fix guest cleanup
* Remove the temporary workaround pointing to a specific `ref`

Related pull requests:

* teemtee/upgrade#18
* teemtee/upgrade#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psss psss psss approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

@mmacura311 mmacura311 Awaiting requested review from mmacura311

Assignees

No one assigned

Labels

bug Something isn't working

Projects

planning
Status: done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thrix @psss @mmacura311 @LecrisUT