Skip to content

Use a different package for dependency test#18

Merged
LecrisUT merged 1 commit intomainfrom
psss-required-package
Mar 23, 2026
Merged

Use a different package for dependency test#18
LecrisUT merged 1 commit intomainfrom
psss-required-package

Conversation

@psss
Copy link
Copy Markdown
Member

@psss psss commented Mar 20, 2026

The dummy-test-package-crested package is no more maintained, let's use a different one.

Related pull request:

The `dummy-test-package-crested` package is no more maintained,
let's use a different one.
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 20, 2026
@psss psss added this to planning Mar 20, 2026
@psss psss moved this from backlog to review in planning Mar 20, 2026
@psklenar
Copy link
Copy Markdown
Contributor

Hi,
I noticed the reboot logic could be improved to follow the official Fedora guidelines. I've implemented a fix based on the Fedora Quick Docs in my fork.
If you’re using DNF 5 (starting from Fedora 41+)

Feel free to cherry-pick this commit into your PR:
psklenar/upgrade@3a26809"

anyway, upgrade started, but machine was not upgraded. It was still f43 after the upgrade to f44.
No idea whats happening during the reboot as its not visible from logs :(

testing-farm-internal request --test-type fmf --git-url https://gitlab.cee.redhat.com/psklenar/tft_mine.git --git-ref main --plan "/upgrade/superplan" --compose Fedora-43 --arch x86_64
https://artifacts.osci.redhat.com/testing-farm/108a22f3-9962-4337-bf70-0092e49d2d00/

Copy link
Copy Markdown
Member

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @psss can you confirm again the merge order of these? This one should be merged first and then teemtee/tmt#4725 should go in?


anyway, upgrade started, but machine was not upgraded. It was still f43 after the upgrade to f44. No idea whats happening during the reboot as its not visible from logs :(

It should be independent to this change though right? For now want to focus on getting teemtee/tmt#4725 in

@LecrisUT LecrisUT moved this from review to merge in planning Mar 23, 2026
@psss
Copy link
Copy Markdown
Member Author

psss commented Mar 23, 2026

@psss can you confirm again the merge order of these? This one should be merged first and then teemtee/tmt#4725 should go in?

Yes, whenever 4725 is at the top of the merge queue, this one should be merged, 4725 test jobs restarted to make sure everything works fine with the new required package and merge.

@psss
Copy link
Copy Markdown
Member Author

psss commented Mar 23, 2026

Feel free to cherry-pick this commit into your PR: psklenar/upgrade@3a26809"

@psklenar, thanks for the hint. Actually, we've discussed using dnf5 offline reboot here:

There @mmacura311 suggested this is low-level functionality not expected to be used by users:

Hi @psss
according the documentation
https://docs.fedoraproject.org/en-US/quick-docs/upgrading-fedora-offline/
the user should run dnf system-upgrade download ... and afterwards dnf system-upgrade reboot so TBH I do not see a need to run the dnf5 offline which looks like lower-level functionality to perform offlne transactions.

Now I see that dnf5 offline reboot is also mentioned in the upgrade docs. So not completely sure.

anyway, upgrade started, but machine was not upgraded. It was still f43 after the upgrade to f44. No idea whats happening during the reboot as its not visible from logs :(

Hmmm, does it seem to be limited to f43-to-f44 scenario? I just checked a recent upgrade job which exercises f42-to-f43 and there everything seems to be working just fine.

@LecrisUT
Copy link
Copy Markdown
Member

Well, will merge and go ahead with teemtee/tmt#4725. We can figure out the rest with the subsequent PRs that are coming

@LecrisUT LecrisUT merged commit 2b8fe4e into main Mar 23, 2026
@LecrisUT LecrisUT deleted the psss-required-package branch March 23, 2026 11:34
@github-project-automation github-project-automation bot moved this from merge to done in planning Mar 23, 2026
psss added a commit to teemtee/tmt that referenced this pull request Mar 23, 2026
The `dummy-test-package-crested` package is no more maintained, let's
use a different one.

* Update require to use `tree` instead
* Rename `finish` to `cleanup` to fix guest cleanup
* Remove the temporary workaround pointing to a specific `ref`

Related pull requests:

* teemtee/upgrade#18
* teemtee/upgrade#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

4 participants