Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions e2e/harmony/create.e2e.4.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,19 @@ describe('create extension', function () {
});
});
describe('external package manager mode', () => {
let pkgJson;
before(() => {
// create a new workspace that uses an external package manager
helper.scopeHelper.cleanWorkspace();
helper.command.init('--external-package-manager');
helper.command.create('module', 'simple');
pkgJson = helper.fs.readJsonFile('package.json');
});
it('should write dependencies to package.json', () => {
const pkgJson = helper.fs.readJsonFile('package.json');
expect(pkgJson.dependencies.eslint != null).to.eq(true);
it('should write dependencies of the component to package.json', () => {
expect(pkgJson.dependencies['@bitdev/node.node-env'] != null).to.eq(true);
});
it('should not write dependencies of the env to package.json', () => {
expect(pkgJson.dependencies.eslint == null).to.eq(true);
});
it('should not run installation', () => {
expect(helper.fs.exists('node_modules/eslint')).to.eq(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,16 @@ export class WorkspaceManifestFactory {
});

const defaultPeerDependencies = await this._getDefaultPeerDependencies(component, packageNames);
const usedPeerDependencies = pickBy(defaultPeerDependencies, (_val, pkgName) => {
return (
depManifestBeforeFiltering.dependencies[pkgName] ||
depManifestBeforeFiltering.devDependencies[pkgName] ||
depManifestBeforeFiltering.peerDependencies[pkgName]
);
});

depManifest.dependencies = {
...defaultPeerDependencies,
...usedPeerDependencies,
...unresolvedRuntimeMissingRootDeps,
...additionalDeps,
...depManifest.dependencies,
Expand Down