fix: don't install dependencies of the env as dependencies of the user component #10150
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the same options to _getComponentsManifests in writeDependenciesToPackageJson as used in _installModules to ensure consistent dependency calculation for external package manager mode.
zkochan
force-pushed
the
fix/deps-of-env-installed-in-root
branch
from
ac86b38 to
e388df0
Compare
davidfirst
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where environment dependencies were incorrectly being installed as dependencies of user components. The fix adds filtering logic to ensure only actually-used peer dependencies from the environment are included in the component's dependencies.
Key Changes:
- Introduced filtering of default peer dependencies to only include those present in the component's actual dependency list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related PR: