-
-
Notifications
You must be signed in to change notification settings - Fork 52
feat(no-unused-class-name): Support Regex for allowedClassNames
option
#1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baseballyama
merged 9 commits into
sveltejs:main
from
tbashiyy:feat/support-regex-no-unused-class-names-allowed-class-names
Jun 26, 2025
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ba742ee
support regex
tbashiyy b8341ac
update docs
tbashiyy 4bb242a
add changeset
tbashiyy 81fd63b
update
tbashiyy e4c983b
use toRegExp
tbashiyy 06cbf3f
simplifier
tbashiyy be7c580
update
tbashiyy 1d6105d
tidy
tbashiyy 893b19f
fix path
tbashiyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'eslint-plugin-svelte': patch | ||
--- | ||
|
||
feat: support regex for allowedClassNames of no-unused-class-name rule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...svelte/tests/fixtures/rules/no-unused-class-name/invalid/allowed-class-names/_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"options": [{ "allowedClassNames": ["div-class"] }] | ||
"options": [{ "allowedClassNames": ["div-class", "/^p-\\d{1,2}$/"] }] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,7 @@ | |
line: 3 | ||
column: 1 | ||
suggestions: null | ||
- message: Unused class "p-100". | ||
line: 5 | ||
column: 1 | ||
suggestions: null |
2 changes: 2 additions & 0 deletions
2
...unused-class-name/invalid/allowed-class-names/partially-allowed-class-name01-input.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
<div class="div-class">Hello</div> | ||
|
||
<span class="span-class">World!</span> | ||
|
||
<span class="p-100">Regex!</span> |
2 changes: 1 addition & 1 deletion
2
...n-svelte/tests/fixtures/rules/no-unused-class-name/valid/allowed-class-names/_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"options": [{ "allowedClassNames": ["div-class", "span-class"] }] | ||
"options": [{ "allowedClassNames": ["div-class", "span-class", "/^p-\\d{1,2}$/"] }] | ||
} |
2 changes: 2 additions & 0 deletions
2
...es/rules/no-unused-class-name/valid/allowed-class-names/allowed-class-name01-input.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
<div class="div-class">Hello</div> | ||
|
||
<span class="span-class">World!</span> | ||
|
||
<span class="p-2">Regex!</span> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
isRegExp
fromutils/regexp.js
to check theclassName
is regexp or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
fixed. e4c983b