feat(no-unused-class-name): Support Regex for allowedClassNames option
#1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 893b19f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tbashiyy
changed the title
allowedClassNamesallowedClassNames option
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
tbashiyy
changed the title
allowedClassNames optionallowedClassNames option
Comment on lines
60
to
71
| if ( | ||
| !allowedClassNames.includes(className) && | ||
| !allowedClassNames.some((allowedClassName: string) => { | ||
| const regex = /^\/(.*)\/$/.exec(allowedClassName); | ||
| if (regex == null || regex[1] == null) { | ||
| return false; | ||
| } | ||
|
|
||
| return new RegExp(regex[1]).test(className); | ||
| }) && | ||
| !classesUsedInStyle.includes(className) | ||
| ) { |
There was a problem hiding this comment.
Please use isRegExp from utils/regexp.js to check the className is regexp or not.
There was a problem hiding this comment.
thanks!
fixed. e4c983b
Comment on lines
62
to
70
| !allowedClassNames.includes(className) && | ||
| !allowedClassNames.some((allowedClassName: string) => { | ||
| if (!isRegExp(allowedClassName)) { | ||
| return false; | ||
| } | ||
|
|
||
| return toRegExp(allowedClassName).test(className); | ||
| }) && | ||
| !classesUsedInStyle.includes(className) |
There was a problem hiding this comment.
I think this is simpler?
Suggested change
| !allowedClassNames.includes(className) && | |
| !allowedClassNames.some((allowedClassName: string) => { | |
| if (!isRegExp(allowedClassName)) { | |
| return false; | |
| } | |
| return toRegExp(allowedClassName).test(className); | |
| }) && | |
| !classesUsedInStyle.includes(className) | |
| allowedClassNames.none((allowedClassName) => { | |
| if (isRegExp(allowedClassName)) { | |
| return toRegExp(allowedClassName).test(className); | |
| } | |
| return allowedClassName === className; | |
| }) && | |
| !classesUsedInStyle.includes(className) |
There was a problem hiding this comment.
Yes, I think this code is enough. (All Test cases passed)
.changeset/forty-signs-smoke.md
Outdated
| 'eslint-plugin-svelte': minor | ||
| --- | ||
|
|
||
| feat(no-unused-class-name): Support Regex for allowedClassNames option |
There was a problem hiding this comment.
Suggested change
| feat(no-unused-class-name): Support Regex for allowedClassNames option | |
| feat(no-unused-class-name): support regex for `allowedClassNames` option |
|
CI is failed. |
| @@ -4,6 +4,7 @@ import type { AnyNode } from 'postcss'; | |||
| import type { Node as SelectorNode } from 'postcss-selector-parser'; | |||
| import { findClassesInAttribute } from '../utils/ast-utils.js'; | |||
| import type { SourceCode } from '../types.js'; | |||
| import { toRegExp } from 'src/utils/regexp.js'; | |||
There was a problem hiding this comment.
Please use relative path to specify the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I use this rule for project which is using
unocss, I want to add unocss's dynamic-rules toallowedClassNamesex)
/^m-(\d+)$/