Skip to content

Switch default to UTF-8 in RestClientResponseException #23764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Switch default to UTF-8 in RestClientResponseException #23764

wants to merge 1 commit into from

Conversation

ask4gilles
Copy link

closes #23738

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 7, 2019
@ask4gilles
Copy link
Author

Hi @sbrannen and @jhoeller ,
Sorry to ping but this one is a one liner which would prevent us writing a custom error handler, so if you would have a minute to have a look :) Thanks!

@rstoyanchev rstoyanchev changed the title defaults to UTF-8. Switch default to UTF-8 in RestClientResponseException Oct 15, 2019
@rstoyanchev rstoyanchev added type: task A general task in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 15, 2019
@rstoyanchev rstoyanchev mentioned this pull request Oct 15, 2019
Closed
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Oct 15, 2019 •
edited
Loading

Note that the same decision also applies to the WebClient, in DefaultClientResponse#createException() which then determines the encoding for resulting WebClientResponseException.

@sdeleuze, @poutsma, following the change in #22788, JSON responses no longer specify a charset as per RFC 7159 defaulting to UTF-8. However client exceptions use ISO-8859-1 if no charset is specified. I suggest we switch the default to UTF-8 starting in 5.2 and also add an overloaded getResponseBodyAsString(Charset) to RestClientResponseException and WebClientResponseException starting in 5.1.x for additional control. WDYT?

@rstoyanchev
Copy link
Contributor

@ask4gilles please refrain from pings on issues like that. What may be a one-liner for you could become a time sink for others and for us if not carefully considered.

@rstoyanchev rstoyanchev added this to the 5.1.11 milestone Oct 15, 2019
@rstoyanchev rstoyanchev self-assigned this Oct 15, 2019
@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 15, 2019
@rstoyanchev rstoyanchev modified the milestones: 5.1.11, 5.2.1 Oct 15, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Oct 15, 2019
@spring-projects-issues spring-projects-issues mentioned this pull request Oct 15, 2019
Closed
@rstoyanchev rstoyanchev mentioned this pull request Oct 16, 2019
Closed
rstoyanchev added a commit that referenced this pull request Oct 23, 2019
@rstoyanchev
Charset argument in RestClientResponseException
2733511 
See gh-23764
rstoyanchev added a commit that referenced this pull request Oct 23, 2019
@rstoyanchev
Merge pull request #23764 from ask4gilles/23738
88ec452
@frasch1712 frasch1712 mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: task A general task
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.

Consider defaulting to UTF-8 in RestClientResponseException
3 participants
@ask4gilles @rstoyanchev @spring-projects-issues