Skip to content

Consider defaulting to UTF-8 in RestClientResponseException #23738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ask4gilles opened this issue Oct 1, 2019 · 1 comment
Closed

Consider defaulting to UTF-8 in RestClientResponseException #23738

ask4gilles opened this issue Oct 1, 2019 · 1 comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another

Comments

@ask4gilles
Copy link

ask4gilles commented Oct 1, 2019 •
edited
Loading

Spring version: 5.2.0.RELEASE

Related to #22954 and the UTF-8 charset removal, the RestClientResponseException now defaults to ISO_8859_1 here

spring-framework/spring-web/src/main/java/org/springframework/web/client/RestClientResponseException.java

Line 105 in 3a0f309

if (this.responseCharset == null) {

instead of UTF-8 previously.

To mitigate this issue, we are now forced to create a custom ResponseErrorHandler and forcing UTF-8
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 1, 2019
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Oct 1, 2019
@ask4gilles ask4gilles mentioned this issue Oct 7, 2019
Closed
@rstoyanchev rstoyanchev added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 15, 2019
@rstoyanchev
Copy link
Contributor

This issue is superseded by #23764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch default to UTF-8 in RestClientResponseException ask4gilles/spring-framework
4 participants
@sbrannen @rstoyanchev @ask4gilles @spring-projects-issues