Skip to content

fix: added mutex in param for thread safety #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: added mutex in param for thread safety #457

wants to merge 1 commit into from

Conversation

mdydek
Copy link
Collaborator

@mdydek mdydek commented May 20, 2025 •
edited
Loading

Closes RNAA-56

Introduced changes

  • added mutex and logic behind locking functionalities that use eventsQueue, in order to not allow race condition between JS and audio thread

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@mdydek
Copy link
Collaborator Author

mdydek commented May 21, 2025

We are currently investigating possible options to achieve this, since approach introduced in this PR lowers efficiency of library ~10%.

@mdydek mdydek added the fix label May 21, 2025
@mdydek mdydek mentioned this pull request May 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdydek