Thread safety

[orange4glace]

Feature Request

I think RNAPI needs to be more thread safe, for example,
Things like AudioParam.eventsQueue_ can be accessed on both JS thread and Audio thread,
so changing param value while playing audio might cause crash.
(Correct me if I'm wrong)

[maciejmakowski2003]

I will investigate it

[maciejmakowski2003]

Thanks for your vigilance!

[AlirezaHadjar]

@maciejmakowski2003 I'm not sure but this could the reason our app crash in the release mode. I ported over our api from expo-av to react-native-audio-api and everything works seemlessly in the debug app but when I test it on the release app, it insta crashes as soon as I call AudioContext.decodeAudioDataSource(file). I tried to replicate the issue in a fresh project but it worked fine there. I really appreciate any help here

And here is the sentry log of the crash

[mdydek]

@orange4glace, we've tried to add locks (#457) also in AudioParam. But simply adding them, sadly caused significant performance drop. After discussing with team, we have agreed to firstly, refactor logic behind retrieving its values and then focus on being more thread-safe. We hope that it will increase performance, and we would be able to implement locks without mentioned drop. It will be on our roadmap, stay tuned!