deps: upgrade zip.js #480
Open
deps: upgrade zip.js #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the directory permission bug that broke ZIP files on Mac/Linux. Dumper Companion needs to use either 2.7.61+ or 2.7.56 and lower.
|
I took some time to investigate the problem yesterday and the new zip.js version is still not correct as it now misses the directory bit in the permission mask. |
|
In the meantime, I'll reopen the other PR so we can at least revert to the old version and have dumper companion working in the interim. |
|
I issued the PR gildas-lormeau/zip.js#569 to fix the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the directory permission bug that broke ZIP files on Mac/Linux. Dumper Companion needs to use either 2.7.61+ or 2.7.56 and lower.
Replacement for #479 now that a fixed release is out.