deps: downgrade zip.js to 2.7.56 #479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.7.57 and newer have a bug which creates incorrect subdirectory permissions when ZIP files are opened on Unix systems (macOS, Linux, etc.). See: gildas-lormeau/zip.js#567
Closed
|
Closing in favour of #480. |
|
I applied my suggested workaround to avoid downgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7.57 and newer have a bug which creates incorrect subdirectory permissions when ZIP files are opened on Unix systems (macOS, Linux, etc.). The version pin can be removed once there's a new version with fixed permissions.
If you use a Unix OS, you can test this on the currently-live version of dumper companion by trying to extract an ISO containing subdirectories. The subdirectories will be created as
-rw-r--r--@, with no executable permissions, and so both the terminal and GUI file browsers like Finder will refuse to let the user access those directories.See: gildas-lormeau/zip.js#567