schedulers: add macro support to metadata variables #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57519702 |
|
This pull request was exported from Phabricator. Differential Revision: D57519702 |
jason-b-akers
force-pushed
the
export-D57519702
branch
from
a4bf5af to
f414e8c
Compare
jason-b-akers
added a commit
to jason-b-akers/torchx
that referenced
this pull request
Jun 17, 2024
Summary: Pull Request resolved: pytorch#921 This adds torchx.spec.macros support to the metadata variable values. This allows use cases like setting smcBridge to the app_id eg: ``` job_spec.roles[0].metadata["mast"] = { "HpcTaskGroupSpec": { "smcBridge": { "portName": "thrift", "smcTier": specs.macros.app_id, } } } ``` Reviewed By: manav-a Differential Revision: D57519702
|
This pull request was exported from Phabricator. Differential Revision: D57519702 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D57519702 |
Summary: Pull Request resolved: pytorch#921 This adds torchx.spec.macros support to the metadata variable values. This allows use cases like setting smcBridge to the app_id eg: ``` job_spec.roles[0].metadata["mast"] = { "HpcTaskGroupSpec": { "smcBridge": { "portName": "thrift", "smcTier": specs.macros.app_id, } } } ``` Reviewed By: manav-a Differential Revision: D57519702
jason-b-akers
force-pushed
the
export-D57519702
branch
from
f414e8c to
c747213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57519702 |
manav-a
approved these changes
Jun 17, 2024
kiukchung
reviewed
Jun 17, 2024
| @@ -189,8 +190,25 @@ def apply(self, role: "Role") -> "Role": | |||
| role = copy.deepcopy(role) | |||
| role.args = [self.substitute(arg) for arg in role.args] | |||
| role.env = {key: self.substitute(arg) for key, arg in role.env.items()} | |||
| role.metadata = self._apply_nested(role.metadata) | |||
There was a problem hiding this comment.
could you add a test-case for this?
There was a problem hiding this comment.
There is a test case on the meta side of this make me can also add a version of it to api test @jason-b-akers
There was a problem hiding this comment.
Hi @kiukchung. There's an internal test in D58678835. As a follow-up I'll write one in torchx/schedulers/test/api_test.py as well.
There was a problem hiding this comment.
Follow-up test in PR#923
jason-b-akers
added a commit
to jason-b-akers/torchx
that referenced
this pull request
Jun 18, 2024
Summary: Adds unit test covering metadata macros. Post-merge follow-up for PR#921: pytorch#921 requested by kiukchung. Differential Revision: D58713685
jason-b-akers
added a commit
to jason-b-akers/torchx
that referenced
this pull request
Jun 18, 2024
Summary: Pull Request resolved: pytorch#923 Adds unit test covering metadata macros. Post-merge follow-up for PR#921: pytorch#921 requested by kiukchung. Reviewed By: manav-a Differential Revision: D58713685
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
Differential Revision: D58713685 Pull Request resolved: #923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds torchx.spec.macros support to the metadata variable values. This allows use cases like setting smcBridge to the app_id eg:
Reviewed By: manav-a
Differential Revision: D57519702