Skip to content

Upgrade vulkan #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Upgrade vulkan #12355

merged 1 commit into from
Jul 10, 2025

Conversation

ahmtox
Copy link
Contributor

@ahmtox ahmtox commented Jul 10, 2025

Summary:

Context

In order to make use of dotPacked4x8EXT, an extension that would make matrix multiplication a little more optimal in the GPU, this diff aims to upgrade the vulkan environment to the minimum version necessary for this function, which happens to be 1.3. This also adds additionally functionality that wouldn't have been otherwise available on just 1.1

Reviewed By: SS-JIA

Differential Revision: D77049180

cc @SS-JIA @manuelcandales @cbilgin

Summary:
# Context

In order to make use of dotPacked4x8EXT, an extension that would make matrix multiplication a little more optimal in the GPU, this diff aims to upgrade the vulkan environment to the minimum version necessary for this function, which happens to be 1.3. This also adds additionally functionality that wouldn't have been otherwise available on just 1.1

Reviewed By: SS-JIA

Differential Revision: D77049180
@ahmtox ahmtox requested a review from SS-JIA as a code owner July 10, 2025 18:30
Copy link

pytorch-bot bot commented Jul 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12355

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit 8fe099f with merge base 540fa5d (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 10, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77049180

@ahmtox ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jul 10, 2025
@facebook-github-bot facebook-github-bot merged commit bdbad3f into main Jul 10, 2025
96 of 103 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D77049180 branch July 10, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants