Skip to content

Upgrade vulkan #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backends/vulkan/runtime/gen_vulkan_spv.py
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,8 @@ def compile_spirv(shader_paths_pair):
src_file_name = shader_paths_pair[0]
# path of template file used for codegen
src_file_fullpath = shader_paths_pair[1][0]
# args used for codegen
codegen_params = shader_paths_pair[1][1]

# Assume that generated files will have the same file extension as the
# source template file.
Expand Down Expand Up @@ -917,6 +919,7 @@ def compile_spirv(shader_paths_pair):
shutil.copyfile(cached_spv_out_path, spv_out_path)
return (spv_out_path, gen_out_path)

vk_version = codegen_params.get("VK_VERSION", "1.1")
# Only proceed if a GLSL compiler was specified
if self.glslc_path is not None:
cmd_base = [
Expand All @@ -925,7 +928,7 @@ def compile_spirv(shader_paths_pair):
gen_out_path,
"-o",
spv_out_path,
"--target-env=vulkan1.1",
"--target-env=vulkan{}".format(vk_version),
"-Werror",
] + [
arg
Expand Down
Loading