Add portable rand kernel implementation #11127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
requested review from
jathu,
larryliu0820,
kirklandsign,
manuelcandales and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11127
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit d538ff7 with merge base 28cbc2b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
added
the
release notes: ops & kernels
| #include <executorch/kernels/portable/cpu/scalar_utils.h> | ||
| #include <executorch/runtime/kernel/kernel_includes.h> | ||
|
|
||
| #include <random> |
There was a problem hiding this comment.
This may not be available in embedded devices. Foe example, zephyr has different API https://docs.zephyrproject.org/apidoc/latest/group__random__api.html
There was a problem hiding this comment.
Yeah, this is generally true, though FYI Scott W has already been using std random for other ops. I'm open to changing it. But we might need to provide implementations as part of the Cortex M workstream.
manuelcandales
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a portable operator implementation for ATen rand. This is a core op that we previously have not had a kernel for.
Test plan
I've added operator-level tests for rand. It's relatively sparse, but validates that the mean and stdev are reasonably sane, as well as that the operator functions correctly for different dtypes, ranks, and sizes.