Skip to content

[redis] Don't recommend uninstalling types-redis #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 3 commits into from
Sep 12, 2023
Merged

[redis] Don't recommend uninstalling types-redis #10694

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b628a3f
[redis] Don't recommend uninstalling types-redis
srittau Sep 11, 2023
fea6364
Add an extra_description
srittau Sep 11, 2023
0be916b
Update stubs/redis/METADATA.toml
srittau Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion stubs/redis/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@ upstream_repository = "https://github.com/redis/redis-py"
# Requires a version of cryptography with a `py.typed` file
requires = ["cryptography>=35.0.0", "types-pyOpenSSL"]
partial_stub = true
obsolete_since = "5.0.0" # Released on 2023-08-15
# While upstream added a py.typed file, the upstream annotations are rather
# incomplete. By using "obsolete_since" we recommend deinstalling this
# package, which isn't the best idea at the moment.
# obsolete_since = "5.0.0" # Released on 2023-08-15
extra_description = """\
Note: Redis-py 5.0.0 added a py.typed file, but the inline annotations \
are incomplete. Continuing to use `types-redis` for the time being may \
lead to superior results.\
"""

[tool.stubtest]
ignore_missing_stub = true
Expand Down