feat(auth): Phase C Wave 2 — Login end-to-end Store5 migration

[therajanmaurya]

Summary

Phase C Wave 2 — second end-to-end feature wave. Follows the Wave 1 template (merged via #2686) and applies it to the login flow.

The login flow is harder than activate because the VM has to:

1. Run pre-submit validation (username + password length) that doesn't go through SubmitHandler
2. On Submitted, persist the user via prefManager.updateUser (side effect) BEFORE navigating
3. Handle the auth-rejected case (response.authenticated != true) by routing to ShowError
4. Surface navigation as a one-shot event (passcode intent), not a state

MVI's LoginState + LoginEvent + LoginAction triple handles this cleanly: state holds validation errors (replayable), events emit NavigateToPasscode / ShowError(StringResource) (one-shot), actions are Submit(username, password) / DismissError.

Changes (21 files; +280 / -310 net)

core/network/auth/

• NEW core/network/auth/api/AuthApi.kt — suspend Ktorfit interface for POST authentication returning PostAuthenticationResponse. Future OTP / refresh / logout endpoints land here.
• core/network/di/NetworkModule.kt: + single { get<Ktorfit>().createAuthApi() }
• Method-level @Deprecated on DataManagerAuth.login + ClientService.authenticate — both stay compileable for un-migrated callers.

core/data/auth/

• git mv core/data/repository/LoginRepository.kt → core/data/auth/LoginRepository.kt
• git mv core/data/repositoryImp/LoginRepositoryImp.kt → core/data/auth/impl/LoginRepositoryImpl.kt
• LoginRepositoryImpl constructor: (authApi: AuthApi) — no DataManagerAuth.
• RepositoryModule.kt: import update + singleOf(::LoginRepositoryImpl) bind LoginRepository::class. Repository binding stays in core/data per the Koin DI ownership boundary.

core/domain

• DELETED useCases/LoginUseCase.kt (pure delegator)
• UseCaseModule.kt: removed factoryOf(::LoginUseCase) + import.
• Kept: UsernameValidationUseCase, PasswordValidationUseCase (validators).

feature/auth/{ui, di, navigation}/ restructure

Old flat layout (feature/auth/login/{LoginViewModel, LoginScreen, LoginUiState}.kt) eliminated. New:

feature/auth/.../
├── ui/
│   ├── LoginState.kt     — validation-error data class (pre-submit gate)
│   ├── LoginAction.kt    — sealed Submit / DismissError
│   ├── LoginEvent.kt     — sealed NavigateToPasscode / ShowError(StringResource)
│   ├── LoginViewModel.kt — extends BaseViewModel<LoginState, LoginEvent, LoginAction>
│   │                       with SubmitHandler<PostAuthenticationResponse>
│   └── LoginScreen.kt    — submit overlay + snackbar + passcode nav; 3 @Preview functions
├── di/
│   └── AuthModule.kt     — viewModelOf(::LoginViewModel) ONLY (no Repository binding)
└── navigation/
    ├── LoginRoute.kt     — @Serializable object (split from AuthNavigation)
    └── AuthNavigation.kt — NavGraphBuilder.authNavGraph + nav extensions

VM logic flow:

• handleAction(Submit(u, p)) → validate inputs → if valid, submit.submit { repo.login(u, p) }
• submit.state.collect { ... }:
  • Submitted → check response.authenticated == true; if yes, persist user + emit NavigateToPasscode; if no, emit ShowError
  • Failed → emit ShowError(feature_auth_error_login_failed)
• handleAction(DismissError) → submit.reset() after snackbar consumes the error event

Screen consumes stateFlow (validation errors) + submitState (submitting overlay) + eventFlow (one-shot navigation/error).

No hardcoded user-facing strings

New composeResources/values/strings.xml entries:

• feature_auth_update_server_configuration
• feature_auth_cd_arrow_forward
• feature_auth_cd_error_icon
• feature_auth_cd_password_visibility

All button labels and content descriptions consume stringResource(...). Log strings (Logger.d("Login", ...)) remain as literals — allowed per plan (log tags are not user-facing).

feature/auth/build.gradle.kts

• + implementation(projects.core.ui) (for BaseViewModel)
• core.data + core.domain kept (validators stay in domain)
• No direct coreBase.* deps

Grep invariants

Check	Result
grep -rn "DataState|asDataStateFlow" feature/auth/ core/data/.../auth/ core/domain/useCases/LoginUseCase*	zero matches
grep -rn "template\.core\.base" feature/auth/	1 match (KptTheme — Theme, accessed via api chain)
grep -rn "DataManagerAuth|ClientService\.authenticate" feature/auth/ core/data/.../auth/	zero matches (repository uses AuthApi)
User-facing string literals in feature/auth/src/commonMain/kotlin/	zero (only Logger.d tags remain)

Test plan

• ./gradlew :feature:auth:build compiles cleanly
• ./gradlew :cmp-android:assembleDebug succeeds; Koin DI resolves
• Login happy path: enter creds → progress overlay → passcode screen
• Login failure (wrong creds): progress overlay → error snackbar → dismiss
• Validation-only failure: short username → inline error on field, no network call
• Auth-rejected case (server returns authenticated: false): error snackbar
• Compose Multiplatform Previews render in IDE: Idle / Submitting / ValidationError variants

Phase status

• ✅ Phase A (infra sync)
• ✅ Phase B (core/store seam)
• ✅ Phase C Wave 1 — activate (merged via #2686)
• 🟢 Phase C Wave 2 — auth (this PR)
• 🔵 Waves 3–7 (search, search-record, groups, center, note, document, offline, path-tracking, collectionSheet, report, savings, recurringDeposit, checker-inbox-task, loan, client, data-table, settings/passcode)
• 🔵 Phase D — batch-delete deprecated DataManagers + Services + BaseApiManager + FlowConverterFactory + DataState + legacy Mifos* composables

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• development

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 714ac328-41e8-4835-a8ae-25ac11fce584

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud