feat(search): Phase C Wave 3 — Search end-to-end Store5 migration

[therajanmaurya]

Summary

End-to-end migration of the Search feature to the kmp-project-template Store5 architecture. This is Wave 3 of Phase C (the per-feature wave) — the first read-only feature wave, following Wave 1 (activate, mutation) and Wave 2 (auth, mutation).

Layers touched

Network (core/network)

• New SearchApi (Ktorfit, suspend) at com.mifos.core.network.search.api.SearchApi — returns List<SearchedEntity> directly, no Flow / no Call wrapper
• Registered in NetworkModule (single { get<Ktorfit>().createSearchApi() })
• @Deprecated on SearchService.searchResources and DataManagerSearch.searchResources — to be deleted in Phase D

Data (core/data)

• New ScreenTypes.kt adds ScreenState<T> / DataFreshness / ScreenDataStream<T> typealiases over the template.core.base.store.screen.* originals
• SearchRepository interface relocated com.mifos.core.data.repository → com.mifos.core.data.search
• Implementation rewritten as com.mifos.core.data.search.impl.SearchRepositoryImpl — uses SearchApi, suspend, no DataState/Flow
• RepositoryModule updated to bind the new impl
• RoomSubmitOutbox.toEntry refactored from runCatching { ... }.getOrNull() to explicit try/catch per project rule (no runCatching in production code — see plan rule update)

Feature (feature/search)

• Restructured to {ui, di, navigation, components} subpackages
• SearchViewModel extends BaseViewModel<SearchScreenState, Nothing, SearchAction> (MVI)
• SearchScreenState owns resultState: ScreenState<List<SearchedEntity>> — SearchResultState (legacy 4-state sealed) deleted
• SearchScreen uses ScreenContent<List<SearchedEntity>> with custom empty slot that distinguishes "initial blank screen" from "no results for query"
• Components renamed: SearchScreenEvent → SearchAction (UpdateSearchText / ClearSearchText / UpdateSelectedFilter / UpdateExactMatch / PerformSearch)
• SearchNavigation.kt split into SearchRoute.kt (the @Serializable route) + SearchNavigation.kt (the NavGraphBuilder + navigateToSearchScreen extension)
• Accessibility contentDescription strings moved from inline literals to composeResources (feature_search_a11y_*)
• 5 @Preview functions on SearchScreen (Loading / InitialEmpty / NoResults / Content / Error)
• build.gradle.kts deps: projects.core.data + projects.core.ui only — no projects.coreBase.* (per the hard rule pinned in the plan this wave)

Plan rules pinned this wave

Two HARD RULES added to plan-layer/.../store5-adoption/C-features.md:

1. No runCatching in production code — it swallows CancellationException and breaks structured concurrency. Use explicit try/catch (re-throwing CancellationException) for read flows; SubmitHandler<R> handles mutation flows internally.
2. Feature modules NEVER use projects.coreBase.* — only projects.core.*. The core.* modules are the project's facade over the framework; core-base/* deps flow transitively via api(). If a feature needs a template.core.base.* type, add a typealias / pass-through in core/<x>/ and re-run the wave.

Acceptance (G-C wave 3)

• SearchApi exists in core.network.search.api.*, registered in NetworkModule
• SearchRepository lives in core.data.search.*, no Flow<DataState<*>>
• Legacy SearchService.searchResources + DataManagerSearch.searchResources are @Deprecated
• SearchViewModel extends BaseViewModel<S, E, A> and owns ScreenState<List<SearchedEntity>>
• SearchScreen uses ScreenContent and renders Loading / Empty / Error / Content
• feature/search has 4 @Preview states covering Loading / InitialEmpty / NoResults / Content / Error
• feature/search/build.gradle.kts has zero projects.coreBase.* references
• No hardcoded user-facing strings (titles, hints, errors, contentDescriptions) — all from composeResources
• Wave 3 commit base = Wave 2 merge commit (920c6810) ← prior wave is contained

Wave protocol

This branch was cut from upstream/store5Migration after Wave 2 (PR #2687) merged, per the HARD RULE in C-features.md ("ALWAYS sync store5Migration before starting a new wave").

Next

• Wave 4 onward (release lock for client / loan / savings — see plan-layer/.../active/store5-adoption/PLAN.md for the registry).
• Phase D will delete the @Deprecated SearchService.searchResources / DataManagerSearch.searchResources / the legacy SearchUiState (already deleted in this PR) once every wave has landed.

Test plan

• App builds on androidApp + iosApp (smoke test)
• Open SearchScreen from drawer → empty state (no input) renders nothing in the result area
• Type query → tap Search → Loading → Content/Empty/Error per backend response
• Clear button resets to empty state
• Filter chip opens dialog → selecting a filter triggers a new search
• Exact-match checkbox toggles and re-runs search
• Tap a result row → navigates to client/center/group/loan/savings detail

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• development

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3636d30b-813c-4dfa-9f04-ee22298f7c13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud