Skip to content

chore: some ESLint improvements #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/cli.mjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
#!/usr/bin/env node

import process from 'node:process';

import { Argument, Command, Option } from 'commander';

import commands from './commands/index.mjs';
import interactive from './commands/interactive.mjs';
import list, { types } from './commands/list.mjs';
import commands from './commands/index.mjs';
import { errorWrap } from './utils.mjs';

const program = new Command()
Expand Down
6 changes: 3 additions & 3 deletions bin/commands/generate.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import {
DOC_NODE_CHANGELOG_URL,
DOC_NODE_VERSION,
} from '../../src/constants.mjs';
import createGenerator from '../../src/generators.mjs';
import { publicGenerators } from '../../src/generators/index.mjs';
import createNodeReleases from '../../src/releases.mjs';
import { loadAndParse } from '../utils.mjs';
import createGenerator from '../../src/generators.mjs';
import createLinter from '../../src/linter/index.mjs';
import { getEnabledRules } from '../../src/linter/utils/rules.mjs';
import createNodeReleases from '../../src/releases.mjs';
import { loadAndParse } from '../utils.mjs';

const availableGenerators = Object.keys(publicGenerators);

Expand Down
2 changes: 1 addition & 1 deletion bin/commands/lint.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import process from 'node:process';
import createLinter from '../../src/linter/index.mjs';
import reporters from '../../src/linter/reporters/index.mjs';
import rules from '../../src/linter/rules/index.mjs';
import { loadAndParse } from '../utils.mjs';
import { getEnabledRules } from '../../src/linter/utils/rules.mjs';
import { loadAndParse } from '../utils.mjs';

const availableRules = Object.keys(rules);
const availableReporters = Object.keys(reporters);
Expand Down
47 changes: 37 additions & 10 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,16 +1,50 @@
import pluginJs from '@eslint/js';
import eslintConfigPrettier from 'eslint-config-prettier';
import importX from 'eslint-plugin-import-x';
import jsdoc from 'eslint-plugin-jsdoc';
import globals from 'globals';

export default [
// @see https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-and-ignores
pluginJs.configs.recommended,
importX.flatConfigs.recommended,
{
ignores: ['out/', 'src/generators/api-links/test/fixtures/'],
},
{
files: ['**/*.mjs'],
rules: {
'import-x/namespace': 'off',
'import-x/no-named-as-default': 'off',
'import-x/no-named-as-default-member': 'off',
'import-x/no-unresolved': 'off',
'import-x/order': [
'error',
{
groups: [
'builtin',
'external',
'internal',
['sibling', 'parent'],
'index',
'unknown',
],
'newlines-between': 'always',
alphabetize: {
order: 'asc',
caseInsensitive: true,
},
},
],
},
},
{
files: ['src/**/*.mjs', 'bin/**/*.mjs'],
plugins: {
jsdoc: jsdoc,
},
languageOptions: { globals: globals.node },
languageOptions: {
ecmaVersion: 'latest',
globals: { ...globals.nodeBuiltin },
},
rules: {
'jsdoc/check-alignment': 'error',
'jsdoc/check-indentation': 'error',
Expand Down Expand Up @@ -39,15 +73,8 @@ export default [
'jsdoc/require-param': 'off',
},
},
// @see https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-and-ignores
{
files: ['src/generators/legacy-html/assets/*.js'],
languageOptions: { globals: { ...globals.browser } },
},
// @see https://eslint.org/docs/latest/rules to learn more about these rules
pluginJs.configs.recommended,
eslintConfigPrettier,
{
ignores: ['src/generators/api-links/test/fixtures/**'],
},
];
Loading
Loading