Skip to content

chore: some ESLint improvements #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2025
Merged

Conversation

araujogui
Copy link
Member

Description

Some ESLint improvements:

  1. Configured eslint-plugin-import-x with the same rules as the website repo to enforce automatic import sorting.
  2. Removed eslint-config-prettier, which is no longer necessary.

Validation

npm run lint

Related Issues

None

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner May 27, 2025 20:36
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (e543fba) to head (2732592).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   90.55%   90.58%   +0.02%     
==========================================
  Files          63       63              
  Lines        4754     4767      +13     
  Branches      191      191              
==========================================
+ Hits         4305     4318      +13     
  Misses        446      446              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
Copy link
Member

Perhaps (for a later date) we make @node-core/eslint-config

@AugustinMauroy
Copy link
Member

Perhaps (for a later date) we make @node-core/eslint-config

That will enter In conlict (in term of meaning) with nodejs/node because with this naming people will thing is design for node core instead of nodejs website thing.

We should definitely open an issue about that because we may need something like @node-website

@araujogui araujogui force-pushed the chore/update-eslint branch from 271a023 to b348eb2 Compare May 28, 2025 12:29
@araujogui araujogui force-pushed the chore/update-eslint branch from 438df90 to 2732592 Compare May 28, 2025 17:13
@araujogui araujogui merged commit c25ec86 into nodejs:main May 28, 2025
7 checks passed
@araujogui araujogui deleted the chore/update-eslint branch May 28, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants