Skip to content

ci: deploy to npm instead of github packages #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

ci: deploy to npm instead of github packages #199

merged 1 commit into from
Jun 7, 2024

Conversation

ryepup
Copy link
Collaborator

@ryepup ryepup commented Jun 6, 2024

Proposed changes

Targets the public npm registry instead of the private github packages to make this as easy to consume as possible.

Drop the dependency on a third party action for tagging, it's only a few lines to add a tag, and the action was broken. Going with one less dependency to keep up with.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Targets the public npm registry instead of the private github packages
to make this as easy to consume as possible.

Drop the dependency on a third party action for tagging, it's only a few lines to
add a tag, and the action was broken. Going with one less dependency to keep up with.
@ryepup ryepup requested a review from danielledeleo June 6, 2024 19:33
@ryepup ryepup merged commit e8e49d7 into main Jun 7, 2024
3 checks passed
@ryepup ryepup deleted the npm-publish branch June 7, 2024 13:22
@ryepup ryepup mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants