Skip to content

Ignore X.509 users in scram secret collision validation #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsierant merged 2 commits into from
Jun 5, 2025
Merged

Ignore X.509 users in scram secret collision validation #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3af6592
Ignore X.509 users in scram secret collision validation
verdel May 14, 2025
301c8bd
Fix conditional based on a suggestion from the PR
verdel May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions mongodb-community-operator/controllers/validation/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,16 @@ func validateUsers(mdb mdbv1.MongoDBCommunity) error {

// Ensure no collisions in the secret holding scram credentials
scramSecretName := user.ScramCredentialsSecretName
if previousUser, exists := scramSecretNameMap[scramSecretName]; exists {
scramSecretNameCollisions = append(scramSecretNameCollisions,
fmt.Sprintf(`[scram secret name: "%s" for user: "%s" and user: "%s"]`,
scramSecretName,
previousUser.Username,
user.Username))
} else {
scramSecretNameMap[scramSecretName] = user
if scramSecretName != "" {
if previousUser, exists := scramSecretNameMap[scramSecretName]; exists {
scramSecretNameCollisions = append(scramSecretNameCollisions,
fmt.Sprintf(`[scram secret name: "%s" for user: "%s" and user: "%s"]`,
scramSecretName,
previousUser.Username,
user.Username))
} else {
scramSecretNameMap[scramSecretName] = user
}
}

if user.Database == constants.ExternalDB {
Expand Down