Skip to content

Conversation

@verdel
Copy link
Contributor

@verdel verdel commented May 14, 2025

Summary

During validation, users without the scramCredentialsSecretName parameter are added to a dictionary with an empty key, which leads to the error mentioned in issue #122.

Closes #122

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@verdel verdel requested a review from a team as a code owner May 14, 2025 15:11
@verdel verdel requested review from fealebenpae and lsierant May 14, 2025 15:11
@nammn
Copy link
Collaborator

nammn commented May 19, 2025

evergreen retry

Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@verdel
Copy link
Contributor Author

verdel commented Jun 3, 2025

@MaciejKaras, Is there anything I can help with to get this PR reviewed faster?

Copy link
Contributor

@lsierant lsierant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lsierant lsierant merged commit d41d45d into mongodb:master Jun 5, 2025
36 checks passed
@verdel verdel deleted the fix-scram-collision-validation branch June 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation error when using x509 for user authentication

4 participants