Skip to content

DOCSP-39717 Transactions Page #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jordan-smith721
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-39717
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/java-rs/DOCSP-39717-transactions/write/transactions/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few comments, but none blocking.

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith

Verified

This commit was signed with the committer’s verified signature.
jordan-smith721 Jordan Smith
@jordan-smith721 jordan-smith721 requested review from a team and vbabanin and removed request for a team August 15, 2024 20:31
@jordan-smith721
Copy link
Collaborator Author

Pinging @vbabanin in case this PR request got lost in the mix

@jordan-smith721
Copy link
Collaborator Author

@rozza - requesting your feedback on this PR as well since I think it covers another ticket that you created a while back (https://jira.mongodb.org/browse/DOCSP-21339).

@jordan-smith721 jordan-smith721 requested a review from rozza August 29, 2024 13:55
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordan-smith721 jordan-smith721 removed the request for review from vbabanin August 29, 2024 16:17
@jordan-smith721 jordan-smith721 merged commit efbe96b into mongodb:main Aug 29, 2024
1 check failed
@jordan-smith721 jordan-smith721 deleted the DOCSP-39717-transactions branch August 29, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants