-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[VitisAI] bugfix model_clone optimization #25629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VitisAI] bugfix model_clone optimization #25629
Conversation
it is related to microsoft#25320 microsoft#23979
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
yes. let's not merge this PR. pls validate the general fix works for you. thank you! |
Based on our comprehensive local testing, we observed that while PR #25626 successfully addresses issues for some models, several others continue to experience the same problems. Therefore, this current PR remains necessary to fully resolve the outstanding issues. cc Guggilla, Nithin Kumar Bader Adam. |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
|
There's another fix in progress: #25652 |
utils::HasExternalData() or utils::HasExternalDataInMemory() This is available from core/framework/tensorprotoutil.h Creating and reading external data is encoded in ExternalData class. The same utils have Unpack() methods that handle all kinds of data within TensorProto Refers to: onnxruntime/core/providers/vitisai/imp/tensor_proto.cc:18 in 1109d03. [](commit_id = 1109d03, deletion_comment = False) |
|
/azp run Test Linux CUDA x64 Release,Test Linux TensorRT x64 Release,Windows GPU Doc Gen CI Pipeline, windows_x64_debug/build_x64_debug (pull_request),web_Debug/build_onnxruntime_web, web_Debug / build_onnxruntime_web |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yuslepukhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
### Description It is related to #25320 #23979. Enable tensor raw data sharing for externalized tensor proto with kTensorProtoMemoryAddressTag ### Motivation and Context With #25320 #23979, all initialized tensor protos are associated with OrtValue, VitisiAI EP need to adapt to this change. Co-authored-by: mingyue <[email protected]>
### Description Cherry-pick the following PRs into `rel-1.23.0`: - #25629 - #25583 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Chunye Wang@AMD <[email protected]> Co-authored-by: mingyue <[email protected]> Co-authored-by: Artur Wojcik <[email protected]> Co-authored-by: urpetkov-amd <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Scott McKay <[email protected]>
### Description It is related to microsoft#25320 microsoft#23979. Enable tensor raw data sharing for externalized tensor proto with kTensorProtoMemoryAddressTag ### Motivation and Context With microsoft#25320 microsoft#23979, all initialized tensor protos are associated with OrtValue, VitisiAI EP need to adapt to this change. Co-authored-by: mingyue <[email protected]>
### Description It is related to microsoft#25320 microsoft#23979. Enable tensor raw data sharing for externalized tensor proto with kTensorProtoMemoryAddressTag ### Motivation and Context With microsoft#25320 microsoft#23979, all initialized tensor protos are associated with OrtValue, VitisiAI EP need to adapt to this change. Co-authored-by: mingyue <[email protected]>
Description
It is related to #25320 #23979. Enable tensor raw data sharing for externalized tensor proto with kTensorProtoMemoryAddressTag
Motivation and Context
With #25320 #23979, all initialized tensor protos are associated with OrtValue, VitisiAI EP need to adapt to this change.