[VitisAI] bugfix model_clone optimization #25707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
yuslepukhin
reviewed
Aug 11, 2025
| *p->mutable_value() = std::string("<") + graph_ptr; | ||
| } else { | ||
| // Under threshold: get the data from ORT_MEM_ADDR and add it to cloned graph | ||
| std::unique_ptr<ONNX_NAMESPACE::TensorProto> tensor_proto; |
Member
yuslepukhin
reviewed
Aug 11, 2025
| } | ||
| } else { | ||
| *cloned_tensor = *original_tensor; | ||
| // ORT 1.22 or ealier intializer handling |
Member
yuslepukhin
reviewed
Aug 11, 2025
| *p->mutable_key() = "location"; | ||
| *p->mutable_value() = std::string("<") + graph_ptr; | ||
| // ORT 1.23 intializer handling | ||
| if (size >= external_data_threshold) { |
Member
yuslepukhin
reviewed
Aug 11, 2025
| *p->mutable_key() = "location"; | ||
| *p->mutable_value() = std::string("<") + graph_ptr; | ||
| } else { | ||
| // Under threshold: get the data from ORT_MEM_ADDR and add it to cloned graph |
Member
There was a problem hiding this comment.
Do not rely on threshold. Some big initializers may not be converted. Use utils to test if the data is external.
We generally do not want YOU to make the decision of what is expected to be an external data in memory.
Use utilities to test and convert.
You can also get a corresponding OrtValue from the graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is related to #25629
Motivation and Context
With #25320 #23979, all initialized tensor protos are associated with OrtValue, VitisiAI EP need to adapt to this change.