Skip to content

Fix in-context translation when no local storage settings #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Fix in-context translation when no local storage settings #1225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
506a213
Flags override default
microbit-grace Jul 2, 2025
e7d48a8
Format changes
microbit-grace Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/common/use-storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export function useStorage<T extends object>(
? localStorageIfPossible()
: sessionStorageIfPossible();
const value = storage ? storage.getItem(key) : null;
const overiddenDefault = { ...defaultValue, ...overrides };
if (value !== null) {
try {
let parsed = JSON.parse(value);
Expand All @@ -44,10 +45,10 @@ export function useStorage<T extends object>(
return parsed;
} catch (e) {
// Better than exploding forever.
return defaultValue;
return overiddenDefault;
}
}
return defaultValue;
return overiddenDefault;
});
const setAndSaveState = useCallback(
(value: T) => {
Expand Down