Skip to content

Fix in-context translation when no local storage settings #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

microbit-grace
Copy link
Contributor

@microbit-grace microbit-grace commented Jul 2, 2025

Task (private)

Fix settings default so that override is applied so that in-context translation works when no local storage setting is set.

Copy link

github-actions bot commented Jul 2, 2025

@microbit-grace microbit-grace force-pushed the translate-empty-settings branch from 3c2cd4d to e7d48a8 Compare July 2, 2025 12:30
@microbit-grace microbit-grace requested a review from a team July 2, 2025 12:37
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-grace microbit-grace merged commit c6f77c0 into main Jul 2, 2025
1 check passed
@microbit-grace microbit-grace deleted the translate-empty-settings branch July 2, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants