fix: resolve_latest_location converts errors to not_found unconditionally#6248
Merged
wkalt merged 1 commit intolance-format:mainfrom Mar 23, 2026
Conversation
Contributor
PR ReviewClean, focused bugfix. The change correctly narrows the No issues found. LGTM. 🤖 Generated with Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… dataset resolve_latest_location can fail for many reasons (I/O errors, permission errors, network failures), but the error was unconditionally wrapped as DatasetNotFound. Now only NotFound errors are converted to DatasetNotFound; all other errors propagate with their original type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wkalt
force-pushed
the
fix/propagate-real-errors-from-resolve-latest-location
branch
from
7d88f0b to
f72185e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_latest_location can fail for many reasons (I/O errors, permission errors, network failures), but the error was unconditionally wrapped as DatasetNotFound. Now only NotFound errors are converted to DatasetNotFound; all other errors propagate with their original type.