Skip to content

WIP: (Predrag) Update go from 1.24.0 to 1.24.2 #20770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

WIP: (Predrag) Update go from 1.24.0 to 1.24.2 #20770

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
949e62b
Update go from 1.24.0 to 1.24.2
minikube-bot May 15, 2025
b0dc298
fix go.hash file and bump go verion in go.mod to 1.24.2
prezha May 15, 2025
98ed416
Updating kicbase image to v0.0.46-1747342779-20770
minikube-bot May 15, 2025
5fc9621
Updating ISO to v1.35.0-1747352413-20770
minikube-bot May 16, 2025
1e43fc2
Updating ISO to v1.35.0-1747425629-20770
minikube-bot May 16, 2025
f8862d0
Merge branch 'master' into auto_bump_golang_version-0810e7b
prezha May 19, 2025
f19d006
Updating ISO to v1.35.0-1747732513-20770
minikube-bot May 20, 2025
f6b90f8
extending integration test timeout from 90m to 120m
prezha May 20, 2025
7720fbf
disable docker :Z selinux relabeling on volume mounts
prezha May 21, 2025
ca5b8eb
Updating ISO to v1.35.0-1747876997-20770
minikube-bot May 22, 2025
883d8bb
debug kvm driver timeout
prezha May 22, 2025
31a4d0e
Updating ISO to v1.36.0-1747963993-20770
minikube-bot May 23, 2025
365e323
Merge branch 'master' into auto_bump_golang_version-0810e7b
prezha May 23, 2025
5de8f1d
ensure libvirt dom.ListAllInterfaceAddresses tries lease source if ar…
prezha May 23, 2025
8fa5e98
Updating ISO to v1.36.0-1748058812-20770
minikube-bot May 24, 2025
88962e8
Merge branch 'master' into auto_bump_golang_version-0810e7b
prezha May 24, 2025
a360b74
debug kvm driver timeout
prezha May 25, 2025
a2c92c1
debug kvm driver timeout
prezha May 25, 2025
d8873a3
debug kvm driver timeout
prezha May 26, 2025
04ba83b
fix kvm driver timeout
prezha May 27, 2025
57d26eb
debug kvm driver timeout
prezha May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deploy/iso/minikube-iso/go.hash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ sha256 36930162a93df417d90bd22c6e14daff4705baac2b02418edda671cdfa9cd07f go1.23
sha256 8d6a77332487557c6afa2421131b50f83db4ae3c579c3bc72e670ee1f6968599 go1.23.3.src.tar.gz
sha256 ad345ac421e90814293a9699cca19dd5238251c3f687980bbcae28495b263531 go1.23.4.src.tar.gz
sha256 d14120614acb29d12bcab72bd689f257eb4be9e0b6f88a8fb7e41ac65f8556e5 go1.24.0.src.tar.gz
sha256 6924efde5de86fe277676e929dc9917d466efa02fb934197bc2eba35d5680971 go1.23.4.linux-amd64.tar.gzsha256 9dc77ffadc16d837a1bf32d99c624cb4df0647cee7b119edd9e7b1bcc05f2e00 go1.24.2.src.tar.gz
sha256 6924efde5de86fe277676e929dc9917d466efa02fb934197bc2eba35d5680971 go1.23.4.linux-amd64.tar.gz
sha256 9dc77ffadc16d837a1bf32d99c624cb4df0647cee7b119edd9e7b1bcc05f2e00 go1.24.2.src.tar.gz
3 changes: 1 addition & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module k8s.io/minikube

go 1.23.4
toolchain go1.24.1
go 1.24.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to make this the minimal required version? This may break people using packages from minikube.

Copy link
Member

@medyagh medyagh May 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good feedback, I would accept a PR that updated the Automation to not bump the minor version in go mod.
I think it would probably best to Match what kubernetes does.
which they dont bump the patch version for go mod
https://github.com/kubernetes/kubernetes/blob/master/go.mod

Copy link
Contributor

@prezha prezha May 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i pulled in go version from the current go.mod (v1.24.0) and resolved the conflicts


require (
cloud.google.com/go/storage v1.52.0
Expand Down